WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#17786 closed defect (bug) (invalid)

Admin Bar CSS Theme Override Bug

Reported by: jtsternberg Owned by: jtsternberg
Milestone: Priority: normal
Severity: normal Version: 3.2
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

Found another bug conflicting with themes, specifically Genesis.

Attachments (2)

17786.diff (443 bytes) - added by jtsternberg 4 years ago.
admin bar css reset addition
17786.patch (375 bytes) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (8)

@jtsternberg4 years ago

admin bar css reset addition

comment:1 @jtsternberg4 years ago

  • Cc justin@… added

comment:2 @ocean904 years ago

From Genesis style.css:

/* Navigation Constants
------------------------------------------------------------ */

li:hover ul ul,
li.sfHover ul ul {
	left: -9999px;
}

comment:3 @nacin4 years ago

  • Cc nathanrice added

This won't make it into 3.2. So this sounds like this is something Genesis could fix on their end, instead.

@ocean904 years ago

comment:4 @ocean904 years ago

17786.patch will use an existing definition and resets right too.

comment:5 @jtsternberg4 years ago

Probably is something they can fix, but i think it's equally important that the Admin Bar doesn't effect the page layout as well as being resilient against being modified by theme code. If not 3.2, then 3.2.1?

comment:6 @helenyhou3 years ago

  • Component changed from UI to Toolbar
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Took a look at Genesis now - seems to have made the selector more specific with .menu, which seems appropriate, and still compensates for the toolbar, which may not be necessary anymore. I would think that the previous selectors would have adversely affected regular content as well.

Note: See TracTickets for help on using tickets.