WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 14 years ago

#17786 closed defect (bug) (invalid)

Admin Bar CSS Theme Override Bug

Reported by: jtsternberg Owned by: jtsternberg
Priority: normal Milestone:
Component: Toolbar Version: 3.2
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Found another bug conflicting with themes, specifically Genesis.

Attachments (2)

17786.diff​ (443 bytes ) - added by jtsternberg 15 years ago.
admin bar css reset addition
17786.patch​ (375 bytes ) - added by ocean90 15 years ago.

Download all attachments as: .zip

Change History (8)

@jtsternberg
15 years ago

admin bar css reset addition

#1 @jtsternberg
15 years ago

  • Cc justin@… added

#2 @ocean90
15 years ago

From Genesis style.css:

/* Navigation Constants
------------------------------------------------------------ */

li:hover ul ul,
li.sfHover ul ul {
	left: -9999px;
}

#3 @nacin
15 years ago

  • Cc nathanrice added

This won't make it into 3.2. So this sounds like this is something Genesis could fix on their end, instead.

@ocean90
15 years ago

#4 @ocean90
15 years ago

17786.patch will use an existing definition and resets right too.

#5 @jtsternberg
15 years ago

Probably is something they can fix, but i think it's equally important that the Admin Bar doesn't effect the page layout as well as being resilient against being modified by theme code. If not 3.2, then 3.2.1?

#6 @helenyhou
14 years ago

  • Component UI → Toolbar
  • Milestone Awaiting Review
  • Resolution → invalid
  • Status new → closed

Took a look at Genesis now - seems to have made the selector more specific with .menu, which seems appropriate, and still compensates for the toolbar, which may not be necessary anymore. I would think that the previous selectors would have adversely affected regular content as well.

Note: See TracTickets for help on using tickets.