WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#17790 closed defect (bug) (fixed)

Gallery css issue (RTL-Arabic)

Reported by: rasheed Owned by: dd32
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: RTL Keywords: has-patch
Focuses: Cc:

Description

Hello,

Please check the attachment.

  1. it should be margin-left instead of margin-right.

#sort-buttons span {

margin-right: 25px;

}

  1. I think these small boxes should be placed in the (Order) column.currently it is placed in the (Actions) column.

Attachments (2)

Untitled-1.gif (34.4 KB) - added by rasheed 9 years ago.
sort-buttons.diff (523 bytes) - added by yoavf 9 years ago.

Download all attachments as: .zip

Change History (8)

@rasheed
9 years ago

#1 @yoavf
9 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.2

Attaching a patch for 1
For 2- it's not an RTL only issue, but a wp wide issue. Need to check if there's an open ticket about that.

@yoavf
9 years ago

#2 @dd32
9 years ago

2 is a odd one, The contents below the header isn't actually a table.. however the header is.. eitherway, that's the same in the English version (and the mis-alignment of the header vs. field is also in English).

Looking at the patch, and the screenshot, it looks to be saying the sorting buttons needs to be flush with the right of the table, whereas, the patch makes it flush to the right (as i'd assume) - Is that correct? it looks like this was the same in 3.1 as well?

#3 @yoavf
9 years ago

dd32 - correct: the arrow on the screenshot is wrong imho - the sorting labels need to be on the left, not on the right (mirroring the LTR).

#4 @dd32
9 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In [18309]:

Flip the Gallery header sort buttons to the left for RTL. Props yoavf. Fixes #17790

#5 @dd32
9 years ago

I've opened #17802 for the 2nd issue mentioned here.

#6 @dd32
9 years ago

In [18311]:

Bump the CSS versions for RTL changes. See #17790 #17791 #17796 & #17799

Note: See TracTickets for help on using tickets.