WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17815 closed defect (bug) (fixed)

Hardcoded messages in wp-include/functions.php

Reported by: mako09 Owned by: nbachiyski
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

In function dead_db() of wp-include/functions.php, there are hardcoded messages.

	<title>Database Error</title>
	<h1>Error establishing a database connection</h1>

Attachments (2)

17815.diff (719 bytes) - added by mako09 3 years ago.
17815.patch (776 bytes) - added by SergeyBiryukov 3 years ago.
Patch against trunk root, with a bit more descriptive WP_I18N comment

Download all attachments as: .zip

Change History (5)

mako093 years ago

comment:1 Nao3 years ago

  • Owner set to nbachiyski
  • Status changed from new to assigned

Nikolay, this is a simple patch to fix a couple of missing *WP_I18N_ comments.
I assigned you the ticket - could you review when you have a chance?

SergeyBiryukov3 years ago

Patch against trunk root, with a bit more descriptive WP_I18N comment

comment:2 SergeyBiryukov3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.3

Would be nice to fix this along with #18180.

comment:3 ryan3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [18724]:

Mark some string in dead_db() for translation. Props mako09, SergeyBiryukov. fixes #17815

Note: See TracTickets for help on using tickets.