Fatal Error on General Settings when Timezone string is invalid.

[westi]

If an enterprising user manages to get an invalid value in this option the General Settings page is completely broken:

[19-Jun-2011 08:03:27] PHP Fatal error:  Uncaught exception 'Exception' with message 'DateTimeZone::__construct() [<a href='datetimezone.--construct'>datetimezone.--construct</a>]: Unknown or bad timezone (Garbage)' in .../wp-admin/options-general.php:187Stack trace:
#0 .../wp-admin/options-general.php(187): DateTimeZone->__construct('Garbage')#1 {main}
  thrown in .../wp-admin/options-general.php on line 187

[westi]

Fix the Fatal Error and sanitize the option on save in future

[westi]

Note with the above fix the user who has set the dodgy data still gets these Warnings and Notices:

    WARNING: wp-includes/functions.php:4082 - timezone_open() [function.timezone-open]: Unknown or bad timezone (Garbage)
    WARNING: wp-includes/functions.php:126 - timezone_open() [function.timezone-open]: Unknown or bad timezone (Garbage)
    WARNING: wp-includes/functions.php:127 - date_create() expects parameter 2 to be DateTimeZone, boolean given
    WARNING: wp-includes/functions.php:130 - date_format() expects parameter 1 to be DateTime, boolean given

    NOTICE: wp-admin/options-general.php:176 - date_default_timezone_set() [function.date-default-timezone-set]: Timezone ID 'Garbage' is invalid

I would be happy to leave fixing these till 3.3 :)

[westi]

Also note in theory a valid timezone could become invalid in future if it disappears from the map :)

[ryan]

Inserted invalid timezone string. Verified that the patched options-general.php avoid the fatal error. Selected valid timezones and verified they were properly saved. Looks good.

[westi]

In [18323]:

Ensure we have a valid timezone identifier before trying to use it.
Validate the new timezone identifier during option update.
Fixes #17840.

[nacin]

Bad westi :-)

[westi]

Replying to nacin:

Bad westi :-)

Good Catch.