WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 14 years ago

Last modified 14 years ago

#17842 closed defect (bug) (fixed)

Style var tag in Twenty Eleven

Reported by: mfields Owned by: nacin
Priority: normal Milestone: 3.4
Component: Bundled Theme Version: 3.2
Severity: normal Keywords: has-patch dev-feedback
Cc: Focuses:

Description

var tags are currently not styled differently than other tags. Would it be a good idea to style them like code and kbd?

Attachments (1)

17842.diff​ (929 bytes ) - added by mfields 15 years ago.
Add var and samp elements to style.css and editor-style.css.

Download all attachments as: .zip

Change History (9)

#1 @mfields
15 years ago

  • Cc michael@… added

#2 @PeteMall
15 years ago

  • Summary Style var tag in wenty Eleven → Style var tag in Twenty Eleven

#3 @peterhol
15 years ago

  • Cc peterhol added

Should perhaps be added to editor-style.css as well?

#4 @mfields
15 years ago

Actually, the var tag seems to be accounted for in Twenty Eleven's editor-style.css, but only when used as a child of a "code" element.

#5 @nacin
15 years ago

Looks good. Also samp could be added. Let's cover editor-style.css too.

@mfields
15 years ago

Add var and samp elements to style.css and editor-style.css.

#6 @mfields
15 years ago

I've updated the patch adding the samp element and accounting for editor-style.css.

#7 @nacin
14 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In [20906]:

Twenty Eleven: Style the samp and var elements the same way we style the code and kbd elements. props mfields, fixes #17842.

#8 @SergeyBiryukov
14 years ago

  • Milestone Awaiting Review → 3.4
Note: See TracTickets for help on using tickets.