Make WordPress Core

Opened 21 years ago

Closed 20 years ago

#1785 closed enhancement (fixed)

Atom-based comment feed

Reported by: kurtmckee Owned by: rob1n
Priority: normal Milestone: 2.2
Component: General Version: 2.1
Severity: normal Keywords: has-patch needs-testing dev-feedback
Cc: Focuses:

Description

I've created an Atom 0.3 comment feed. Holizz (holizz.com) updated the code to be Atom 1.0 compliant. It is coded against WordPress 1.5.2.

Attachments (3)

wp-commentsatom.php​ (3.7 KB ) - added by kurtmckee 21 years ago.
wp-commentsatom.2.php​ (3.8 KB ) - added by kurtmckee 21 years ago.
Fixed incorrect xml:base and id output
1785.diff​ (5.2 KB ) - added by rob1n 20 years ago.

Download all attachments as: .zip

Change History (15)

@kurtmckee
21 years ago

Fixed incorrect xml:base and id output

#1 @davidhouse
21 years ago

  • Keywords bg|has-patch added

#2 @matt
21 years ago

  • Milestone 1.6 → 2.1
  • Priority normal → low

#3 @_ck_
20 years ago

  • Priority low → normal

Note for the wp-commentsatom.php to work correctly with rewritten urls in Wordpress 2.x this function has to be updated to the following in wp-includes/functions.php

function do_feed_atom($for_comments) {
if ( $for_comments ) {
load_template(ABSPATH . 'wp-commentsatom.php');
} else {
load_template(ABSPATH . 'wp-atom.php');
}
}

Wordpress is WAY overdue to have working ATOM 1.0 feeds and it's super easy to add into the next alpha release with all the groundword already done.

#4 @matt
20 years ago

  • Milestone 2.1 → 2.2

#5 @rob1n
20 years ago

  • Keywords dev-feedback added; atom comments feed bg|has-patch removed
  • Owner changed from anonymous to rob1n
  • Status new → assigned

Is this something that the devs want in the core?

Also, the patch is outdated. I can work on a new one.

#6 @rob1n
20 years ago

Waiting on feedback.

#7 @rob1n
20 years ago

(Out-of-Trac feedback)

#8 @ryan
20 years ago

Add the template as wp-includes/feed-atom-comments.php.

Update do_feed_atom() to handle withcomments.

Update do_feed() to not assume comment feeds are always rss2.

#9 @rob1n
20 years ago

  • Keywords dev-feedback removed
  • Version 1.6 → 2.1

I'm on it. :)

@rob1n
20 years ago

#10 @rob1n
20 years ago

  • Cc rboren added
  • Keywords has-patch needs-testing dev-feedback added

Added preliminary patch that NEEDS looking over. I *believe* I did everything right, but then again...

#11 @rob1n
20 years ago

Okay, I found one error already: I use bloginfo_rss('content_type') instead of bloginfo_rss('html_type'). I'll fix this in the morning.

#12 @ryan
20 years ago

  • Resolution → fixed
  • Status assigned → closed

(In [4928]) Atom comments feed. First pass. Props kurtmckee and rob1n. fixes #1785

Note: See TracTickets for help on using tickets.