WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 5 months ago

#17862 closed enhancement (fixed)

The second argument for wp_notify_postauthor() is unnecessary

Reported by: scribu Owned by: westi
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch commit
Focuses: Cc:

Description

Only the comment id is needed. See patch.

Attachments (4)

17862.diff (2.2 KB) - added by scribu 3 years ago.
17862.2.diff (2.6 KB) - added by scribu 3 years ago.
Clarification in wp_new_comment()
17862.3.diff (2.7 KB) - added by wonderboymusic 5 months ago.
17862.4.diff (1.3 KB) - added by markjaquith 5 months ago.
simplest version, for non-conflict with #25699 patches

Download all attachments as: .zip

Change History (7)

scribu3 years ago

scribu3 years ago

Clarification in wp_new_comment()

comment:1 SergeyBiryukov6 months ago

  • Milestone changed from Future Release to 3.8

wonderboymusic5 months ago

comment:2 wonderboymusic5 months ago

  • Keywords commit added

.3.diff makes the patch apply against trunk and adds our new required braces​

comment:3 westi5 months ago

  • Owner set to westi
  • Resolution set to fixed
  • Status changed from new to closed

In 26358:

Deprecate the second argument for wp_notify_postauthor because it is unecessary. Fixes #17862 props scribu and wonderboymusic.

markjaquith5 months ago

simplest version, for non-conflict with #25699 patches

Note: See TracTickets for help on using tickets.