Context Navigation

← Previous Ticket
Next Ticket →

#17864 closed defect (bug) (fixed)

Small bug when using "wp_delete_file" filter

Reported by:	DuGi_dk	Owned by:	Morten Rugaard
Priority:	normal	Milestone:	4.2
Component:	Media	Version:	3.1.3
Severity:	minor	Keywords:	has-patch
Cc:		Focuses:

Description

Hi,

I came acrossed this little annoying bugger, when I was playing around with upload filters.

When I added the "wp_delete_file", I kept getting this error:

Notice: Undefined index: path in /volume1/web/dev/favola_dk/wp-includes/post.php on line 3757

I then digged down in the line, where the error was occuring and I find this little bugger (the bold line is line 3757):

// remove intermediate and backup images if there are any
foreach ( get_intermediate_image_sizes() as $size ) {
        if ( $intermediate = image_get_intermediate_size($post_id, $size) ) {
                $intermediate_file = apply_filters('wp_delete_file', $intermediate['path']);
                @ unlink( path_join($uploadpath['basedir'], $intermediate_file) );
        }
}

I noticed when I var_dump() the $size, that "path" is not within the array at any time. And the funny thing is, if you go down the next block in the code you'll see this:

if ( is_array($backup_sizes) ) {
        foreach ( $backup_sizes as $size ) {
                $del_file = path_join( dirname($meta['file']), $size['file'] );
                $del_file = apply_filters('wp_delete_file', $del_file);
                @ unlink( path_join($uploadpath['basedir'], $del_file) );
        }
}

Here it uses the index "file", which is the one I was expecting to recieve in the former block.

Attachments (2)

17864.diff (3.3 KB ) - added by scribu 15 years ago.: first pass, covering wp_delete_attachment()
17864.2.diff (6.3 KB ) - added by scribu 15 years ago.: cover all 'wp_delete_file' filter references