Small bug when using "wp_delete_file" filter

[DuGi_dk]

Hi,

I came acrossed this little annoying bugger, when I was playing around with upload filters.

When I added the "wp_delete_file", I kept getting this error:

Notice: Undefined index: path in /volume1/web/dev/favola_dk/wp-includes/post.php on line 3757

I then digged down in the line, where the error was occuring and I find this little bugger (the bold line is line 3757):

// remove intermediate and backup images if there are any
foreach ( get_intermediate_image_sizes() as $size ) {
        if ( $intermediate = image_get_intermediate_size($post_id, $size) ) {
                $intermediate_file = apply_filters('wp_delete_file', $intermediate['path']);
                @ unlink( path_join($uploadpath['basedir'], $intermediate_file) );
        }
}

I noticed when I var_dump() the $size, that "path" is not within the array at any time. And the funny thing is, if you go down the next block in the code you'll see this:

if ( is_array($backup_sizes) ) {
        foreach ( $backup_sizes as $size ) {
                $del_file = path_join( dirname($meta['file']), $size['file'] );
                $del_file = apply_filters('wp_delete_file', $del_file);
                @ unlink( path_join($uploadpath['basedir'], $del_file) );
        }
}

Here it uses the index "file", which is the one I was expecting to recieve in the former block.

[scribu]

Please paste your code, that which you hook to 'wp_delete_file'.

[scribu]

In all cases, the callback should receive a path. It seems that in some cases it's relative, while in others it's not.

I noticed that there are too many places where the 'wp_delete_file' filter is called manually.

We should make a wp_delete_file() helper function. Patch incoming.

[scribu]

first pass, covering wp_delete_attachment()

[scribu]

cover all 'wp_delete_file' filter references

[nacin]

Sorry, we didn't get to this in 3.9, but I'm gonna try to consolidate this again in 4.0.

[SergeyBiryukov]

#28828 was marked as a duplicate.

[wonderboymusic]

In 31575:

Make a new function, wp_delete_file(). Use it.

Props scribu, wonderboymusic.
Fixes #17864.

[ocean90]

@wonderboymusic Anything left here? Inline docs?

[DrewAPicture]

Let's call this fixed for 4.2. The inline docs changes in [31575] seem fine to me.