WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17867 closed defect (bug) (worksforme)

Credits Page - Fatal error: Only variables can be passed by reference.

Reported by: studionashvegas Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

Running the RC1 Nightly, and this pops up on my credits page.

Fatal error: Only variables can be passed by reference in /blahblahblah/wp-admin/credits.php on line 116

Change History (10)

#1 @studionashvegas
5 years ago

  • Keywords close added

Fixed in the RC2

#2 @nacin
5 years ago

  • Milestone changed from Awaiting Review to 3.2

Nothing changed since RC1. Moving to 3.2 for review. Let's get an extra set of eyes on this.

#3 @aaroncampbell
5 years ago

I'm definitely not seeing this one. shuffle() is pass-by-reference so it requires a variable, and it's even been on line 116 for a while, but I don't see that we've ever passed it anything but a variable.

I can't reproduce.

#4 follow-up: @studionashvegas
5 years ago

It was really strange because I saw the error on RC1, created the Trac ticket, upgraded to RC2, and it fixed itself. Should I check it on an RC1 fresh install?

#5 in reply to: ↑ 4 @nacin
5 years ago

  • Keywords reporter-feedback added; needs-patch removed

Replying to studionashvegas:

It was really strange because I saw the error on RC1, created the Trac ticket, upgraded to RC2, and it fixed itself. Should I check it on an RC1 fresh install?

Yeah, if you can, that'd be great. Need to know what's going on there. What version of PHP?

#6 @nacin
5 years ago

  • Milestone changed from 3.2 to Awaiting Review

#7 @edwardw
5 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

Seems to be fine as of trunk revision 18519.

#8 @aaroncampbell
5 years ago

This was definitely NOT fixed in [18519]. I agree with closing as worksforme, but I wanted to point out that it wasn't fixed there in case anyone checks this in the future.

#9 @ocean90
5 years ago

  • Keywords close reporter-feedback removed
  • Milestone Awaiting Review deleted

edwardw says that revision 18519 was his current version on which he tested it again.

#10 @aaroncampbell
5 years ago

I realized that, but not until I had checked the revision to see what had fixed it only to see that it was completely unrelated. I just wanted to make sure anyone else happening by didn't have to do the same thing.

Note: See TracTickets for help on using tickets.