WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 18 months ago

#17870 closed defect (bug) (fixed)

Featured image on post types

Reported by: kevindees Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch reporter-feedback
Focuses: Cc:

Description

I have found that the admin area has a bug were if the featured image is larger than the meta box it overlaps the box.

http://screensnapr.com/v/Do2DrO.png

attached a fix. see below css.

#postimagediv img { max-width: 100%; }

Attachments (1)

featureimagefix.css (38 bytes) - added by kevindees 3 years ago.
css fix

Download all attachments as: .zip

Change History (5)

kevindees3 years ago

css fix

comment:1 follow-up: SergeyBiryukov3 years ago

  • Keywords reporter-feedback added

Steps to reproduce? The image should be resized on-the-fly to 266px:

<img class="attachment-post-thumbnail" width="266" ... />

Code reference:
http://core.trac.wordpress.org/browser/tags/3.2.1/wp-admin/includes/post.php#L1230

comment:2 in reply to: ↑ 1 kevindees3 years ago

Replying to SergeyBiryukov:

Steps to reproduce? The image should be resized on-the-fly to 266px:

<img class="attachment-post-thumbnail" width="266" ... />

Code reference:
http://core.trac.wordpress.org/browser/tags/3.2.1/wp-admin/includes/post.php#L1230

Would it not be better to do this with css as well in general? I do not know why this happens but it has not be isolated to one installation.

As far as the php function goes I couldn't say what is going on. Could be the dimensions of the images throwing the calc off.

comment:3 MikeHansenMe18 months ago

  • Cc mdhansen@… added
  • Keywords close added

This appears to be resolved in the current version of trunk (3.5-beta1-22204) in the admin css file on line 3333-3334

#select-featured-image img {
	max-width: 100%;

Proposing close as fixed.

Last edited 18 months ago by MikeHansenMe (previous) (diff)

comment:4 SergeyBiryukov18 months ago

  • Keywords close removed
  • Milestone changed from Awaiting Review to 3.5
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.