WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#17873 closed defect (bug) (fixed)

Add menu id for admin-bar's dashboard and view-site link

Reported by: 423300 Owned by: ryan
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: General Keywords: has-patch
Focuses: Cc:

Description

Please add menu id for them, So I can use remove_menu to remove them out

Attachments (1)

17873-add-menu-id.diff (1.7 KB) - added by szadok 8 years ago.

Download all attachments as: .zip

Change History (10)

#1 @nacin
8 years ago

  • Milestone changed from Awaiting Review to 3.2

#2 @szadok
8 years ago

My first contribution to WordPress :)
Added "view-site" id and "dashboard" id to the menu.
@nacin, if it is ok - close the bug.

#3 follow-up: @nacin
8 years ago

  • Keywords has-patch added

Looks good. Can you check other add_menu calls in the file for missing IDs? I saw at least one.

#4 in reply to: ↑ 3 @szadok
8 years ago

Replying to nacin:

Looks good. Can you check other add_menu calls in the file for missing IDs? I saw at least one.


Repatched: added also id = "edit-profile" to "Edit My Profile" & id="logout" to "Logout"

#5 @azaozz
8 years ago

+1. Don't think that can break anything in 3.2.

#6 @ryan
8 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [18333]:

Add menu id for admin-bar's dashboard and view-site link. Props szadok. fixes #17873

#7 @JarretC
8 years ago

  • Cc jarretcade@… added

Maybe it is just me but the logout and dashboard IDs seem a little bit too basic. The logout ID more than the dashboard one but just thinking of possible CSS styling issues that could happen down the road since IDs are meant to be unique on a page.

Maybe something more along the lines of prefixing the IDs with admin-bar- or similar?

#8 @nacin
8 years ago

These are just the internal menu IDs. The admin bar API prepends 'wp-admin-bar-' before turning them into HTML IDs.

#9 @JarretC
8 years ago

Why yes it does...apparently I need to pay attention more!

Note: See TracTickets for help on using tickets.