#17873 closed defect (bug) (fixed)
Add menu id for admin-bar's dashboard and view-site link
Reported by: | 423300 | Owned by: | ryan |
---|---|---|---|
Milestone: | 3.2 | Priority: | normal |
Severity: | normal | Version: | 3.2 |
Component: | General | Keywords: | has-patch |
Focuses: | Cc: |
Description
Please add menu id for them, So I can use remove_menu to remove them out
Attachments (1)
Change History (10)
#3
follow-up:
↓ 4
@
13 years ago
- Keywords has-patch added
Looks good. Can you check other add_menu calls in the file for missing IDs? I saw at least one.
#4
in reply to:
↑ 3
@
13 years ago
Replying to nacin:
Looks good. Can you check other add_menu calls in the file for missing IDs? I saw at least one.
Repatched: added also id = "edit-profile" to "Edit My Profile" & id="logout" to "Logout"
#6
@
13 years ago
- Owner set to ryan
- Resolution set to fixed
- Status changed from new to closed
In [18333]:
#7
@
13 years ago
- Cc jarretcade@… added
Maybe it is just me but the logout and dashboard IDs seem a little bit too basic. The logout ID more than the dashboard one but just thinking of possible CSS styling issues that could happen down the road since IDs are meant to be unique on a page.
Maybe something more along the lines of prefixing the IDs with admin-bar- or similar?
Note: See
TracTickets for help on using
tickets.
My first contribution to WordPress :)
Added "view-site" id and "dashboard" id to the menu.
@nacin, if it is ok - close the bug.