WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17887 closed defect (bug) (fixed)

New stars for gray theme shouldn't have white borders

Reported by: helenyhou Owned by: ocean90
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Graphic Design Keywords: has-patch
Focuses: Cc:

Description

The new stars in the plugin install screen are fantastic, but look funky when using the gray theme because they still have white borders on each side. Patch adds border color #f9f9f9 to colors-fresh.css, does not remove #fff from plugin-install.css - order seems fine.

Related: #17428

Attachments (3)

colors-fresh.diff (77.7 KB) - added by helenyhou 3 years ago.
17887.patch (1.5 KB) - added by ocean90 3 years ago.
17887.diff (1.3 KB) - added by dd32 3 years ago.

Download all attachments as: .zip

Change History (12)

helenyhou3 years ago

comment:1 follow-up: ocean903 years ago

  • Milestone changed from Awaiting Review to 3.2

Patch is okay, next time you doesn't need to patch the compressed files, dev is enough.

comment:2 dd323 years ago

The colour specifications should be moved out of plugin-install.dev.css into their colour specific sheets IMO.

comment:3 dd323 years ago

  • Keywords needs-patch added; has-patch removed

actually. To complicate it, The Stars on the Plugin Information dialogue need the #fff background, whilst the list table needs the #f9f9f9 background, all whilst using the grey scheme. needs-patch based on that.

ocean903 years ago

comment:4 ocean903 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to ocean90
  • Status changed from new to accepted

comment:5 in reply to: ↑ 1 helenyhou3 years ago

Replying to ocean90:

Patch is okay, next time you doesn't need to patch the compressed files, dev is enough.

Good to know; gotta learn somewhere, I guess!

New patch works for me (of course).

dd323 years ago

comment:6 dd323 years ago

attachment 17887.diff added

Just a simplified version of ocean90's patch.

Tested it in the 3 locations we use the stars in both Grey and Blue schemes. (Plugin Info dialogue, Plugin Listing page, Theme Install details pane), retains generic white formatting to fit in any other locations plugins may be using it (but if they are, they'll need to update the filenames anyway)

comment:7 ocean903 years ago

Just a simplified version of ocean90's patch.

Sure, no idea why I haven't done this.

comment:8 azaozz3 years ago

+1 for 17887.diff.

comment:9 dd323 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18362]:

Correct the background colour for the stars. Props ocean90 & helenyhou. Fixes #17887

Note: See TracTickets for help on using tickets.