New stars for gray theme shouldn't have white borders

[helenyhou]

The new stars in the plugin install screen are fantastic, but look funky when using the gray theme because they still have white borders on each side. Patch adds border color #f9f9f9 to colors-fresh.css, does not remove #fff from plugin-install.css - order seems fine.

Related: #17428

[ocean90]

Patch is okay, next time you doesn't need to patch the compressed files, dev is enough.

[dd32]

The colour specifications should be moved out of ​plugin-install.dev.css into their colour specific sheets IMO.

[dd32]

actually. To complicate it, The Stars on the Plugin Information dialogue need the #fff background, whilst the list table needs the #f9f9f9 background, all whilst using the grey scheme. needs-patch based on that.

[helenyhou]

Replying to ocean90:

Patch is okay, next time you doesn't need to patch the compressed files, dev is enough.

Good to know; gotta learn somewhere, I guess!

New patch works for me (of course).

[dd32]

attachment 17887.diff added

Just a simplified version of ocean90's patch.

Tested it in the 3 locations we use the stars in both Grey and Blue schemes. (Plugin Info dialogue, Plugin Listing page, Theme Install details pane), retains generic white formatting to fit in any other locations plugins may be using it (but if they are, they'll need to update the filenames anyway)

[ocean90]

Just a simplified version of ocean90's patch.

Sure, no idea why I haven't done this.

[azaozz]

+1 for 17887.diff.

[dd32]

In [18362]:

Correct the background colour for the stars. Props ocean90 & helenyhou. Fixes #17887