WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#17889 closed defect (bug) (fixed)

Browser nag with no JS has hard to read grey text

Reported by: duck_ Owned by: azaozz
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: General Keywords: has-patch
Focuses: Cc:

Description

See screenshot attached.

If you do not have JavaScript enabled then the browser nag metabox text is the default dark grey which is hard to read and looks strange alongside the white links.

The problem is caused by the ui-sortable class, which is specified in the CSS, not being applied.

Attachments (6)

browser-nag-no-js.png (16.1 KB) - added by duck_ 8 years ago.
17889.diff (451 bytes) - added by duck_ 8 years ago.
17889.2.diff (594 bytes) - added by duck_ 8 years ago.
It's possible to move the color declaration to a different block
17889.3.diff (502 bytes) - added by aaroncampbell 8 years ago.
17889.2.png (44.0 KB) - added by aaroncampbell 8 years ago.
17889-4.patch (1.7 KB) - added by azaozz 8 years ago.

Download all attachments as: .zip

Change History (12)

@duck_
8 years ago

@duck_
8 years ago

It's possible to move the color declaration to a different block

#1 @azaozz
8 years ago

+1 for 17889.2.diff.

#2 @aaroncampbell
8 years ago

17889.2.diff doesn't change the color of the header. You could drop the color definition in #dashboard_browser_nag.postbox h3 as well, but I just combined it with #dashboard_browser_nag a in 17889.3.diff and it looks fine with and without JS.

#3 @nacin
8 years ago

I've always wondered why the font color flickered on refresh. Yes, let's please get this fixed.

@aaroncampbell
8 years ago

@azaozz
8 years ago

#4 @azaozz
8 years ago

17889-4.patch also fixes all other styles that use the .ui-sortable selector.

#5 @aaroncampbell
8 years ago

17889-4.patch seemed to clean things up for me (with and without JS).

#6 @azaozz
8 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18347]:

Fix text color in the browser nag when no JS, props duck_, fixes #17889

Note: See TracTickets for help on using tickets.