delete_post_thumbnail()

[nacin]

set_post_thumbnail() should allow deletes too, by passing false or 0 as the new ID. Or we can add delete_post_thumbnail().

The set-post-thumbnail admin-ajax branch will need a rework to support it.

[kawauso]

+1 for delete_post_thumbnail(), not sure false or 0 on a set function would be expected behaviour given other functions have a delete counterpart.

[jtsternberg]

+1 for delete_post_thumbnail(). what about update_post_thumbnail()?

[CoenJacobs]

delete_post_thumbnail() function isn't that hard

[CoenJacobs]

Still need to work through the admin-ajax branch function.

[CoenJacobs]

Or changed the set_post_thumbnail() function, passing 0 as the new id to remove.

[scribu]

I would go with delete_post_thumbnail().

[jane]

Leads/committers: please weigh in on commit vs. punt based on current patch, given freeze.

[duck_]

Replying to CoenJacobs:

Still need to work through the admin-ajax branch function.

17895.diff. Changed it to return the return value of delete_post_meta.

I'm a bit unsure about returning false if there's no post, but returning true if there's a post with no thumbnail. Seems to me that both cases should return the same? Otherwise should be good :)

[CoenJacobs]

Replying to duck_:

17895.diff. Changed it to return the return value of delete_post_meta.

I'm a bit unsure about returning false if there's no post, but returning true if there's a post with no thumbnail. Seems to me that both cases should return the same? Otherwise should be good :)

Sounds good to me.

Returning false when the delete isn't executed because of no set value in the meta is a choice indeed. Doesn't delete_post_meta (and thus delete_metadata() ) return false too, if there are no records to delete?

[duck_]

Replying to CoenJacobs:

Doesn't delete_post_meta (and thus delete_metadata() ) return false too, if there are no records to delete?

Correct. 17895.2.diff.

[CoenJacobs]

That deletes about half of my function, but yes this seems to be it. :)

[nacin]

In [18767]:

delete_post_thumbnail(). props CoenJacobs, duck_. fixes #17895.