WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #17904, comment 18


Ignore:
Timestamp:
08/14/2013 09:01:28 PM (6 years ago)
Author:
martythornley
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17904, comment 18

    initial v1  
    44> If that can be broken out of the username check and only applied to the sitename, that would be okay.
    55
    6 The create_new_blog() function uses sanitize_user() to sanitize the sitename, so the same filters used for users would be used for sites. But I am not seeing anywhere that there is a fallback to the actual username. During wpmu_validate_blog_signup() it checks new site names and does its own separate lower string check.
     6The create_new_blog() function uses sanitize_user() to sanitize the sitename, so the same filters used for users would be used for sites.
     7
     8So it might be a question of whether you would want to use the same validations for sites as users? Or should there be a separate sanitize_sitename()?
     9
     10But I am not seeing anywhere that there is a fallback to the actual username. During wpmu_validate_blog_signup() it checks new site names and does its own separate lower string check.
    711
    812It seems that removing the strtolower from sanitize user does the trick as long as that is the desired effect?