WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #17904, comment 86


Ignore:
Timestamp:
11/24/2023 04:41:41 AM (13 months ago)
Author:
rajinsharwar
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17904, comment 86

    initial v1  
    1 So, considering the patch of the PR: 3153, we have got 2 new functions introduced:
     1So, considering the patch of the [https://github.com/WordPress/wordpress-develop/pull/3153/ PR: 3153], we have got 2 new functions introduced:
    221. wp_validate_user_login() | wp-includes/user.php
    332. is_username_reserved() | wp-includes/user.php
    … …  
    77We have got the {{{ validate_username()}}}function modified, with an additional parameter being passed. So, we need to update the developer blog as well for that function.
    88
    9 We got 7 NEW strings introduced, and 3 OLD strings being removed. Added:
     9We got 4 NEW strings introduced, and 2 OLD strings being removed. Added:
    1010
    11111. Site names can only contain lowercase letters (a-z), numbers, and hyphens.
    … …  
    13132. Site names can not begin or end with a hyphen.
    1414
    15 3. Please enter a username.
     153. Sorry, that username is invalid. (NOTE: We can use the "Sorry, that username is not allowed" instead of introducing this.
    1616
    17 4. Username must be at least 4 characters. (NOTE: We can edit this to "The Username must be at least of 4 characters".
    18 
    19 5. Sorry, usernames must have letters too!
    20 
    21 6. Sorry, that username is invalid. (NOTE: We can use the "Sorry, that username is not allowed" instead of introducing this.
    22 
    23 7. That username is currently reserved, but it may be available in a couple of days.
     174. That username is currently reserved, but it may be available in a couple of days.
    2418
    2519Removed:
    2620
    27 1. Please enter a username.
     211. This username is already registered. Please choose another one.
    2822
    29 2. This username is already registered. Please choose another one.
    30 
    31 3. Site names can only contain lowercase letters (a-z) and numbers.
     232. Site names can only contain lowercase letters (a-z) and numbers.
    3224
    3325As this change includes major changes for the login and registration functions for multi-site, we will need a DEV note for this as well.