WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17910 closed defect (bug) (fixed)

User Profile JS cleanup

Reported by: azaozz Owned by: azaozz
Milestone: 3.1.4 Priority: normal
Severity: normal Version: 3.1.2
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

Strip tags and maintain string type when updating the "Display name publicly as" drop-down with JS on the User profile screen.

Attachments (4)

17910.patch (914 bytes) - added by azaozz 3 years ago.
17910.diff (726 bytes) - added by dd32 3 years ago.
just for reference, my patch that doesnt include the html striping.
17910-3.patch (863 bytes) - added by azaozz 3 years ago.
17910-4.patch (863 bytes) - added by azaozz 3 years ago.

Download all attachments as: .zip

Change History (12)

azaozz3 years ago

comment:1 azaozz3 years ago

  • Keywords has-patch added

comment:2 nacin3 years ago

  • Milestone changed from Future Release to 3.1.4

comment:3 nacin3 years ago

Any backport to 3.1 will need to use .attr.

dd323 years ago

just for reference, my patch that doesnt include the html striping.

comment:4 dd323 years ago

attachment 17910.diff added

Just for reference, that's what I used, AFAIK, jQuery takes care of the attr/prop by itself when you use that syntax. It doesnt include the HTML striping that azaozz has added however.

azaozz3 years ago

comment:5 azaozz3 years ago

Merged the patch from dd32 with the first one, tested in 3.1 and 3.2.

azaozz3 years ago

comment:6 nacin3 years ago

  • Keywords commit added

+1 on 17910-4.patch.

comment:7 azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18363]:

User Profile JS cleanup, props dd32, fixes #17910 for 3.1

comment:8 azaozz3 years ago

In [18364]:

User Profile JS cleanup, props dd32, fixes #17910 for 3.2

Note: See TracTickets for help on using tickets.