WordPress.org

Make WordPress Core

Opened 8 years ago

Last modified 12 months ago

#17913 new enhancement

Site-level comment options may override individual post settings. Improve help/docs.

Reported by: niallkennedy Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch has-ux-feedback needs-refresh
Focuses: ui Cc:

Description

Post comments may be automatically closed for a site's posts if site option 'close_comments_for_old_posts' is true and the post was published before 'close_comments_days_old' days ago. These two options are set in options-discussion and override the 'comment_status' of an individual post.

The edit posts screen's comment meta box displays comments open/close status, allowing publishers to open or close comments for a single post. It's possible the site-level discussion settings will override the individual post yet we still might display a different post comment status than the site settings allow.

  1. Enable site-level option to close comments on articles ( wp-admin/options-discussion.php#close_comments_for_old_posts )
  2. Enter a days value of 1 for maximum impact
  3. Edit a post published over a day ago
  4. View the Discussion meta box ( #commentstatusdiv )
  5. Interact with the 'comment_status' field

I would like to better communicate expected failure and let the post author or editor know this particular setting has been overridden at the site options level. If the current user can manage options I might you could link to the override in the options page.

I created a new test blog, set comments to auto-close after a day, and checked allow comments in the post screen. I was wondering why comments_open() was false for the post when I was looking at a checked box on the post screen.

Attachments (3)

meta-boxes.diff (1.7 KB) - added by niallkennedy 8 years ago.
Disable comments input checkbox in post meta box if change will have no effect
post-page-enable-comments.jpg (73.1 KB) - added by joyously 23 months ago.
Here is what it looks like now. Regardless of the value of the site Discussion setting "Automatically close comments on articles older than x days", this post-specific checkbox is available.
post-page-closure-message.jpg (74.7 KB) - added by joyously 23 months ago.
This is a proposed solution: to show the actual comment status of the post and still allow it to be changed. The message could include a link to the other setting.

Download all attachments as: .zip

Change History (15)

@niallkennedy
8 years ago

Disable comments input checkbox in post meta box if change will have no effect

#1 @chriscct7
5 years ago

  • Keywords dev-feedback added
  • Severity changed from minor to normal

#2 @DrewAPicture
5 years ago

  • Focuses docs added
  • Summary changed from Site-level comment options may override individual post settings. Improve communication. to Site-level comment options may override individual post settings. Improve help/docs.

Related: #27111

#3 @DrewAPicture
4 years ago

  • Keywords ux-feedback added; dev-feedback removed

I'm not sure if disabling the settings would be the way to go here, though I'd like to get ux-feedback on that. We could add text to the meta box to explain what's going on or override as with the disabling of the inputs. Neither really seems ideal.

#4 @DrewAPicture
4 years ago

  • Focuses docs removed

#5 @karmatosed
4 years ago

If I am understanding this right and because of a configuration the settings can't be changed but look like they can from the front end, then having a disabling makes sense. Having them totally removed makes sense if they can't be used. You could take the approach of also having a message saying why they are removed. I would recommend that only though if the person using the front end wouldn't know - potentially the case.

This ticket was mentioned in Slack in #core-comments by rachelbaker. View the logs.


3 years ago

#7 @rachelbaker
3 years ago

  • Focuses ui added
  • Keywords needs-refresh needs-screenshots added

Looks like @karmatosed weighed in with some initial UX feedback. Sounds like to determine a path forward here we need a refreshed patch and some screenshots for ux-feedback to have some UX to give feedback on.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


23 months ago

#9 @karmatosed
23 months ago

We went through this in this week's triage for the ux-feedback tag. Screenshots and a refreshed patch would still be great.

@joyously
23 months ago

Here is what it looks like now. Regardless of the value of the site Discussion setting "Automatically close comments on articles older than x days", this post-specific checkbox is available.

@joyously
23 months ago

This is a proposed solution: to show the actual comment status of the post and still allow it to be changed. The message could include a link to the other setting.

#10 @joyously
23 months ago

  • Keywords needs-screenshots removed

I agree with Drew that disabling the setting doesn't seem like the way to go. The problem is that the individual post setting is not the only thing that affects the status, so it is not accurate to call this setting a "comment status". The "Allow" verbiage is accurate to indicate that comments are allowed on the post or not, but the whole picture is not presented to the user. In the screenshot above, I show one way to give a more complete status for the individual post. I think it's important that the user can still adjust the option for the post he is editing, even if he has to go somewhere else to make it actually happen. But that could be a good thing if you think about a case where you set all the posts the way you want first, and then change the global setting when they are all ready.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


12 months ago

#12 @karmatosed
12 months ago

  • Keywords has-ux-feedback added; ux-feedback removed
Note: See TracTickets for help on using tickets.