WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17942 closed defect (bug) (fixed)

DFW in multisite needs to check media_buttons

Reported by: nacin Owned by: azaozz
Milestone: 3.2 Priority: high
Severity: normal Version:
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

Originally reported here: ​http://wordpress.org/support/topic/unable-to-upload-media-in-fullscreen-mode?replies=9.

Attachments (2)

17942.diff​ (618 bytes) - added by nacin 3 years ago.
17942-2.patch​ (1.5 KB) - added by azaozz 3 years ago.

Download all attachments as: .zip

Change History (9)

nacin — 3 years ago

comment:1 nacin — 3 years ago

  • Keywords has-patch added

comment:2 follow-up: nacin — 3 years ago

Alternative would be to trigger #add_media, which seems to allow some things, but I don't really know what.

comment:3 in reply to: ↑ 2 vebailovity — 3 years ago

Replying to nacin:

Alternative would be to trigger #add_media, which seems to allow some things, but I don't really know what.

Maybe something along these lines in onclick handler:

(jQuery('#add_image').length ? jQuery('#add_image').click() : jQuery('#add_media').click());return false;

azaozz — 3 years ago

comment:4 azaozz — 3 years ago

Alternatively we can make the Insert Media button in DFW open the Add Media popup on ms if the Add Image button is disabled (the default), as suggested by @nacin.

Last edited 3 years ago by azaozz (previous) (diff)

comment:5 nacin — 3 years ago

  • Keywords commit added

+1 on 17942-2.patch.

comment:6 ryan — 3 years ago

Another +1 on 17942-2.patch

comment:7 azaozz — 3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18380]:

DFW: check if the Add Image button is enabled in ms mode before using it, props nacin, fixes #17942

Note: See TracTickets for help on using tickets.