#17950 closed enhancement (fixed)
Introduce wp_registration_url()
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.6 | Priority: | low |
| Severity: | normal | Version: | |
| Component: | General | Keywords: | has-patch commit |
| Focuses: | Cc: |
Description (last modified by )
It would be handy to have a wp_registration_url() template tag, to complete the wp_login_url() and wp_logout_url() triad.
Attachments (7)
Change History (31)
#1
@
14 years ago
I noticed that wp-login.php itself never uses wp_login_url() so I didn't use wp_register_url() there either.
#4
@
13 years ago
In 17950.2.diff since wp_register_url is filterable, we should probably esc_url when printing the register link. Also, you might want to remove the $redirect variable since it's undefined and we're not going to be using it anyway :)
#5
@
13 years ago
Fixed in 17950.3.diff and also use it in wp-login.php.
#6
@
13 years ago
Something to consider, wp_register_url() could easily be confused to provide functionality to register a URL like register_taxonomy() registers a taxonomy.
Suggestion: Change from verb to noun and call it wp_registration_url().
#7
@
13 years ago
- Description modified (diff)
- Summary changed from Introduce wp_register_url() to Introduce wp_registration_url()
Good idea!
#10
@
13 years ago
We need a decision on the filter name.
17950.4.diff introduces register_url.
#14406 suggests reusing the same register filter we already have in wp_register():
http://core.trac.wordpress.org/browser/tags/3.5/wp-includes/general-template.php#L348
#11
@
13 years ago
I think 'register_url' is fine, because the 'register' hook contains the whole <a> tag.
#13
in reply to:
↑ 12
@
13 years ago
Replying to cartpauj:
I like wp_register_url() personally.
We have wp_login_url() and wp_logout_url() which are both using the noun form ("login" is the noun, "log in" is the verb). Hence why this is using the noun form.
#14
@
13 years ago
- Keywords needs-refresh added
Needs refresh after [23558]. @since 3.3.0 also needs to be updated.
#16
@
13 years ago
There are 3 instances of site_url( 'wp-login.php?action=register', 'login' ) in wp-login.php (see [23558] for line numbers), I guess the third one needs to be replaced as well.
#19
@
13 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In 24053:
$redirect param isn't useful