WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#17958 closed enhancement (maybelater)

Add feature image icon to admin post list

Reported by: christopherross Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.1.4
Component: Administration Keywords: has-patch ux-feedback
Focuses: Cc:

Description

A simple patch to add a copy of the feature image to the admin's post list if one exists.

Attachments (10)

addicon.diff (1.5 KB) - added by christopherross 3 years ago.
new diff for patch to add icon to admin
17958.2.diff (1.6 KB) - added by DH-Shredder 3 years ago.
Refresh of patch with additional spacing
posts-with-thumbs.jpg (49.1 KB) - added by DH-Shredder 3 years ago.
Image showing posts including their featured thumbs
17958.3.diff (2.7 KB) - added by DH-Shredder 3 years ago.
This includes the thumbs for pages as well, if it's desired.
add thumbnail to admin posts - spacing fix.diff (2.6 KB) - added by christopherross 3 years ago.
minor spacing fix around the sizing array
17958.5.onlyformatting.diff (2.5 KB) - added by DH-Shredder 3 years ago.
*only* reformatting of this specific section of the file, with no added icons
17958.5.diff (3.3 KB) - added by DH-Shredder 3 years ago.
Reformatting *and* featured post icons for pages and posts
17958.formatting.diff (2.2 KB) - added by nacin 3 years ago.
17958.6.diff (2.8 KB) - added by DH-Shredder 3 years ago.
Refreshed with nacin's cleanup
17958.7.patch (2.8 KB) - added by chexee 2 years ago.
Aligns thumbnail with top of post title and bottom of action links if post title is one line

Download all attachments as: .zip

Change History (31)

comment:1 follow-up: dd323 years ago

You may want to review the changes there, Most seem to be reverting changes made in 3.2 rather than adding the feature you intended.

Also, when submitting patches, only include the .dev versions of css and js files, the commitor will re-minify it afterwards.

comment:2 in reply to: ↑ 1 christopherross3 years ago

thanks for the tips, I've not submitted a patch before so I really appreciate it. I'll take a look as you've suggested.

comment:3 nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18426]:

Check for WP_Error return values when using get_term_field() to set up nav menu items. fixes #17958 for trunk.

comment:4 nacin3 years ago

In [18427]:

Check for WP_Error return values when using get_term_field() to set up nav menu items. fixes #17958 for 3.2.

comment:5 nacin3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Oops, those belonged on #17968.

christopherross3 years ago

new diff for patch to add icon to admin

comment:6 christopherross3 years ago

I know this patch isn't a high priority or even likely to be included without substantial consideration but it's my first attempt to contribute to the core and would very much appreciate feedback to know if the new patch file is done right, for future reference.

comment:7 nacin3 years ago

That code could use a lot of spacing, but yes, patch is correct.

DH-Shredder3 years ago

Refresh of patch with additional spacing

DH-Shredder3 years ago

Image showing posts including their featured thumbs

DH-Shredder3 years ago

This includes the thumbs for pages as well, if it's desired.

comment:8 scribu3 years ago

  • Keywords has-patch added; needs-testing removed
  • Milestone changed from Awaiting Review to 3.3

That's a pretty neat idea.

I think it's a small-enough patch for 3.3.

comment:9 DH-Shredder3 years ago

Thanks for the feedback!
Per your notes in IRC, I'm also going ahead and cleaning up the formatting in the file in general, since it most certainly can use it.

christopherross3 years ago

minor spacing fix around the sizing array

DH-Shredder3 years ago

*only* reformatting of this specific section of the file, with no added icons

DH-Shredder3 years ago

Reformatting *and* featured post icons for pages and posts

comment:10 DH-Shredder3 years ago

Attached files both with formatting only for this hairy section of code, and with the formatting+change.
I hope to also reformat more of the file (or the entire file), although if the conversion to API/CSS from tables for admin is done in 3.3, this will likely be duplicated effort.

nacin3 years ago

DH-Shredder3 years ago

Refreshed with nacin's cleanup

comment:11 DH-Shredder3 years ago

  • Cc mike.schroder@… added

comment:12 DH-Shredder3 years ago

  • Keywords ux-feedback added

comment:13 DH-Shredder3 years ago

Created #18664 for patches/discussion on cleanup/formatting changes.

comment:14 nacin3 years ago

  • Milestone changed from 3.3 to Awaiting Review
  • Owner nacin deleted
  • Status changed from reopened to reviewing

chexee2 years ago

Aligns thumbnail with top of post title and bottom of action links if post title is one line

comment:15 chexee2 years ago

I really like this. Altered DH-Shredder's patch a bit so the thumbnail is aligned a bit better:

http://chx.mx//1x/qne90hmy2skk4.png

From a user perspective, I think this would really do well to drive home what a featured image is v. including an image in a post. It represents that post on both the front-end and back-end of your site.

comment:16 follow-up: chexee2 years ago

After a bit more testing, the alignment looks good even with multi-line posts.

Noticed it loads the entire 150x150 thumbnail, which might get slow for certain users if they have lots of posts with featured thumbs (even with resized images, might still get pretty slow).

comment:17 in reply to: ↑ 16 ; follow-up: scribu2 years ago

Replying to chexee:

Noticed it loads the entire 150x150 thumbnail, which might get slow for certain users if they have lots of posts with featured thumbs (even with resized images, might still get pretty slow).

It actually depends on how many posts they want to display per screen. I don't think it's worth registering a whole new intermediate image size just for this.

comment:18 in reply to: ↑ 17 nacin2 years ago

Replying to scribu:

Replying to chexee:

Noticed it loads the entire 150x150 thumbnail, which might get slow for certain users if they have lots of posts with featured thumbs (even with resized images, might still get pretty slow).

It actually depends on how many posts they want to display per screen. I don't think it's worth registering a whole new intermediate image size just for this.

I don't think it's worth the extra 20 or more HTTP requests. Seems like a good plugin for now.

comment:19 scribu2 years ago

Agreed. Better not to force this on users.

comment:20 nacin2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.