#17958 closed enhancement (maybelater)
Add feature image icon to admin post list
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | minor | Version: | 3.1.4 |
Component: | Administration | Keywords: | has-patch ux-feedback |
Focuses: | Cc: |
Description
A simple patch to add a copy of the feature image to the admin's post list if one exists.
Attachments (10)
Change History (32)
#2
in reply to:
↑ 1
@
12 years ago
thanks for the tips, I've not submitted a patch before so I really appreciate it. I'll take a look as you've suggested.
#3
@
12 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In [18426]:
#5
@
12 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Oops, those belonged on #17968.
#6
@
12 years ago
I know this patch isn't a high priority or even likely to be included without substantial consideration but it's my first attempt to contribute to the core and would very much appreciate feedback to know if the new patch file is done right, for future reference.
#8
@
12 years ago
- Keywords has-patch added; needs-testing removed
- Milestone changed from Awaiting Review to 3.3
That's a pretty neat idea.
I think it's a small-enough patch for 3.3.
#9
@
12 years ago
Thanks for the feedback!
Per your notes in IRC, I'm also going ahead and cleaning up the formatting in the file in general, since it most certainly can use it.
#10
@
12 years ago
Attached files both with formatting only for this hairy section of code, and with the formatting+change.
I hope to also reformat more of the file (or the entire file), although if the conversion to API/CSS from tables for admin is done in 3.3, this will likely be duplicated effort.
#14
@
12 years ago
- Milestone changed from 3.3 to Awaiting Review
- Owner nacin deleted
- Status changed from reopened to reviewing
@
12 years ago
Aligns thumbnail with top of post title and bottom of action links if post title is one line
#15
@
12 years ago
I really like this. Altered DH-Shredder's patch a bit so the thumbnail is aligned a bit better:
http://chx.mx//1x/qne90hmy2skk4.png
From a user perspective, I think this would really do well to drive home what a featured image is v. including an image in a post. It represents that post on both the front-end and back-end of your site.
#16
follow-up:
↓ 17
@
12 years ago
After a bit more testing, the alignment looks good even with multi-line posts.
Noticed it loads the entire 150x150 thumbnail, which might get slow for certain users if they have lots of posts with featured thumbs (even with resized images, might still get pretty slow).
#17
in reply to:
↑ 16
;
follow-up:
↓ 18
@
12 years ago
Replying to chexee:
Noticed it loads the entire 150x150 thumbnail, which might get slow for certain users if they have lots of posts with featured thumbs (even with resized images, might still get pretty slow).
It actually depends on how many posts they want to display per screen. I don't think it's worth registering a whole new intermediate image size just for this.
#18
in reply to:
↑ 17
@
12 years ago
Replying to scribu:
Replying to chexee:
Noticed it loads the entire 150x150 thumbnail, which might get slow for certain users if they have lots of posts with featured thumbs (even with resized images, might still get pretty slow).
It actually depends on how many posts they want to display per screen. I don't think it's worth registering a whole new intermediate image size just for this.
I don't think it's worth the extra 20 or more HTTP requests. Seems like a good plugin for now.
#20
@
12 years ago
- Milestone Awaiting Review deleted
- Resolution set to maybelater
- Status changed from reviewing to closed
#21
@
12 years ago
And here is such a plugin:
http://wordpress.org/extend/plugins/codepress-admin-columns/screenshots/
You may want to review the changes there, Most seem to be reverting changes made in 3.2 rather than adding the feature you intended.
Also, when submitting patches, only include the .dev versions of css and js files, the commitor will re-minify it afterwards.