WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17962 closed defect (bug) (fixed)

Twenty Eleven loop is confusing when post is password protected

Reported by: helenyhou Owned by: nacin
Milestone: 3.2.1 Priority: normal
Severity: normal Version: 3.2
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

When a post is password protected in Twenty Eleven, you get the text "Enter your password to view comments." under the title, followed by "This post is password protected. To view it please enter your password below:" and the usual password form. This seems redundant and looks really confusing. Since it also shows the comments prompt in the entry-meta, perhaps it would be better not to show the icon at all.

Attached is a screenshot of what it looks like in its current state, and a patch to not show the icon if a password is needed. I may (probably) have missed some places, not being as familiar with Twenty Eleven yet.

Attachments (2)

twentyeleven-password.png (37.4 KB) - added by helenyhou 3 years ago.
17962.diff (3.6 KB) - added by helenyhou 3 years ago.

Download all attachments as: .zip

Change History (12)

helenyhou3 years ago

comment:1 helenyhou3 years ago

I really should say the .entry-header .comments-link instead of icon.

Last edited 3 years ago by helenyhou (previous) (diff)

comment:2 iandstewart3 years ago

  • Version changed from 3.2 to 3.1.4

comment:3 iandstewart3 years ago

  • Version changed from 3.1.4 to 3.2

comment:4 iandstewart3 years ago

It appears I changed the version to 3.1.4 thinking I was changing it to 3.2.1. Anyway, this patch looks OK to me.

comment:5 iandstewart3 years ago

  • Milestone changed from Awaiting Review to 3.2.1

comment:6 nacin3 years ago

Does this affect Twenty Ten?

comment:7 helenyhou3 years ago

No, Twenty Ten only has a comment link in the entry-meta and it looks fine. It's just because of the slick comment bubble in Twenty Eleven :)

comment:8 nacin3 years ago

Looks good.

comment:9 nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18422]:

Twenty Eleven: Don't call comments_popup_link() if post_password_required(). That'll result in double password messages. props helenyhou, fixes #17962 for trunk.

comment:10 nacin3 years ago

In [18423]:

Twenty Eleven: Don't call comments_popup_link() if post_password_required(). That'll result in double password messages. props helenyhou, fixes #17962 for 3.2.

Note: See TracTickets for help on using tickets.