deregistered taxonomy makes menu uneditable

[wpmuguru]

Steps to reproduce:

• register a custom taxonomy (either for posts of for a custom post type)
• add a term under that taxonomy
• create/edit a post and add the term to the post
• publish the post
• edit a nav menu & add the term to the menu
• deactivate the plugin that registers the taxonomy

Attached is a patch that fixes the issue. However, the is_wp_error check in wp_check_invalid_utf8() might not be the appropriate place to catch/mitigate the second WP error.

I'm technically on vacation for the next couple weeks so I'm not setting the priority, etc.

[wpmuguru]

plugin for testing

[wpmuguru]

This is still broken in 3.2. I reproduced the error/white screen at the hackfest yesterday. It's not going to be a widesread issue but white screens should be fixed in the next release.

[nacin]

This looks hairy and possibly a rabbit hole. Attached is an initial patch that tries to correct some WP_Errors to something scalar.

This should handle taxonomies, but haven't tried disappearing custom post types yet. I think get_post() is more forgiving.

[ryan]

17968.2.diff fixes the fatal error and seems good. CPTs are still handled properly when deregistered.

[nacin]

[18426], [18427].

I see other opportunities for a WP_Error object to make its way into a nav menu item on setup. Not sure if we're done here, though we've avoided the obvious errors.

[azaozz]

No patch for 3.2.1 and suggested close.

[nacin]

It's already committed for 3.2.1. Closing. New ticket if someone discovers something new.