WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 19 months ago

#17978 closed defect (bug) (fixed)

Label for "Super Admin" in wp-admin/user-edit.php seems redundant and inconsistent

Reported by: waclawjacek Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: trivial Version: 3.2
Component: Network Admin Keywords: has-patch commit
Focuses: multisite Cc:

Description

Hello :-)

Please excuse me for the harsh words. Explanation coming right up.

The following is the relevant bit of code:

<tr><th><label for="role"><?php _e('Super Admin'); ?></label></th>

(file name wp-admin/user-edit.php, line number in revision 18392: 263).

The label tag seems to be both redundant and inconsistent - redundant, because there's no input field that has the ID "role" on that screen, and inconsistent, because all the other checkbox groups don't have any labels (as in "HTML <label> tags") to the left of them.

Cheers!
WJ

Attachments (1)

patch.diff (793 bytes) - added by waclawjacek 3 years ago.
Patch to the bug. Removes the <label> tag.

Download all attachments as: .zip

Change History (4)

waclawjacek3 years ago

Patch to the bug. Removes the <label> tag.

comment:1 kawauso3 years ago

  • Keywords has-patch added; label super admin user edit network removed

comment:2 nacin19 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.5

comment:3 ryan19 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21927]:

Remove unnecessary label. Props waclawjacek. fixes #17978

Note: See TracTickets for help on using tickets.