WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17980 closed defect (bug) (fixed)

IE6 warning and missing image + change string

Reported by: pavelevap Owned by: nacin
Milestone: 3.3 Priority: lowest
Severity: normal Version: 3.2
Component: General Keywords: has-patch
Focuses: Cc:

Description

There is no icon of Internet Explorer visible in Dashboard warning when using IE6 (see attached screenshot). IE7 and IE8 works well...

Also one string should be changed, there is paragraph tag included which should not be there (or I did not find similar strings - usually paragraph tags are outside translatable string). See attached patch.

Attachments (5)

Missing_IE_image.jpg (25.1 KB) - added by pavelevap 3 years ago.
paragraph_tag.patch (1013 bytes) - added by pavelevap 3 years ago.
paragraph_tag_2.patch (1009 bytes) - added by pavelevap 3 years ago.
Updated patch, thanks to nacin
17980.patch (1.4 KB) - added by SergeyBiryukov 3 years ago.
after.png (37.8 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (12)

pavelevap3 years ago

pavelevap3 years ago

comment:1 follow-up: nacin3 years ago

  • Priority changed from normal to lowest

The string has both <p> and </p> in it. You're right we should remove them, but not until 3.3. Your patch removes <p> but leaves </p>.

Missing IE image, now that's a shame :-) Wondering where it ran off to? Probably a CSS issue.

pavelevap3 years ago

Updated patch, thanks to nacin

comment:2 pavelevap3 years ago

Sorry, I added ending paragraph tag and forgot removing it from original string. Patch updated, thank you.

Yes, I know that WP 3.2 will not support IE6, but showing this informative box about insecure browser should be IE6 friendly. But it is not a big problem, I guess...

comment:3 in reply to: ↑ 1 ramoonus3 years ago

Replying to nacin:

The string has both <p> and </p> in it. You're right we should remove them, but not until 3.3. Your patch removes <p> but leaves </p>.

Missing IE image, now that's a shame :-) Wondering where it ran off to? Probably a CSS issue.

your wrong
its a typical #blaimNacin thing

comment:4 SergeyBiryukov3 years ago

  • Keywords has-patch added

comment:5 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to nacin
  • Status changed from new to accepted

SergeyBiryukov3 years ago

SergeyBiryukov3 years ago

comment:6 SergeyBiryukov3 years ago

17980.patch also fixes the font color and icon position (see the screenshot). IE6 doesn't display PNG alpha transparency properly, but I guess it's not worth hacking.

comment:7 nacin3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18930]:

Make the Browse Happy box look somewhat okay in Internet Explorer. Remove html tags from a string. props SergeyBiryukov, pavelevap. fixes #17980.

Note: See TracTickets for help on using tickets.