WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17994 closed defect (bug) (fixed)

TinyMCE fullscreen mode on custom editors on post edit and plugin page

Reported by: evomase Owned by:
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2
Component: TinyMCE Keywords: 3.3-early
Focuses: Cc:

Description

ISSUE 1:
When clicking on the full screen mode button on a custom editor (post edit page), the content rendered on the full screen window inaccurate. Also, when clicking the update button it updates the default wordpress content editor.

ISSUE 2:
On a plugin page it is a different scenario. When using the wp_tiny_mce function to render the editor, it throws a JS error saying the edCanvas variable isn't defined.

POSSIBLE SOLUTION:
In regards to both issues and looking at the wp-fullscreen.dev.js file, the editor_id is hard coded and hence why it always points to default wordpress editor.

Also is there a way to bind the wordpress tinymce buttons to the current active tinymce editor? At the moment it's hard coded to point to 'content'.

I already addressed this issue on my blog in regards to using the media buttons on custom editors - http://goo.gl/4VVsB

It will be awesome if all wordpress tinymce buttons dynamically picks up the active editor.

Change History (5)

comment:1 nacin3 years ago

  • Keywords needs-refresh removed
  • Milestone changed from Awaiting Review to 3.2.1

comment:2 azaozz3 years ago

  • Keywords 3.3-early added
  • Milestone changed from 3.2.1 to Future Release

Planning to refresh/refactor the_editor() and the helper functions for outputting both editors in 3.3 #17144 and quicktags.js #16695. This will fix all of the above problems and make it a lot easier for plugins to use both editors.

Also plugins can disable the 'wpfullscreen' TinyMCE plugin (remove it from the plugins list) causing the fullscreen button to open the default (old) fullscreen.

comment:3 koopersmith3 years ago

  • Milestone changed from Future Release to 3.3

comment:4 azaozz3 years ago

Thinking that best would be to have the TinyMCE default fullscreen plugin for all pages except the Add New/Edit Post. There we can add DFW to the default editor and leave the tmce fullscreen if there are other editors.

comment:5 azaozz3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In the updated editor API DFW is only enabled for the default editor on the write/edit post screen. All other instances use the TinyMCE (old) fullscreen.

Note: See TracTickets for help on using tickets.