Failure to Update Notification Persists After Manual Upgrade

[Lorelle]

This has been around for a few versions. When an update fails, if the user updates or upgrades manually and WordPress lists the updated version in the Administration Panels, the failure to update notification persists.

I've sat through four or five updates with the failure notice on every panel, including WordPress 3.2, on several sites.

[nacin]

This is by design.

.maintenance will stick around after a failed automatic update. It needs to be removed as part of the manual update steps.

It might be a good idea to change .maintenance to a non-hidden file so it would be easier to delete, but that's about it.

[Lorelle]

Really? Instructions need to be in place on how to remove this as part of the manual update. Are there such instructions? Thanks.

[nacin]

Only if you count Step 1.5: ​http://codex.wordpress.org/Updating_WordPress#Manual_Update.

[Lorelle]

Ah, hadn't noticed that page had been updated.

Still doesn't discount the fact that "I" think this part should be automatic. :D

Thanks,

Lorelle

[nacin]

I think we can automate this a little.

We could store the WP version we're trying to get to in .maintenance, then compare it to $wp_version. If they match, then we could probably assume the update was successful.

MD5 verifications of updates (3.3?) would be another nice touch.

[SergeyBiryukov]

Replying to nacin:

MD5 verifications of updates (3.3?) would be another nice touch.

Related: #20074

[dd32]

Duplicate of #14028.