Press This link (button) - RTL - Arabic

[rasheed]

Hello,

Please check the attachment.

1- The current situation.
2- How it should look in RTL.

The button needs some padding + change background position.

[jkudish]

There previously was a note that said that press this was intentionally not RTLized, not sure why though, so I decide to provide a patch anyways...

Also attached is press-this-rtl.png which is the same icon, but without the sprite that the non-RTL version has (otherwise the little hand shows up on the button). Not sure what the hand is used for, so I chose to ommit it for RTL only.

[jkudish]

here's the patch again (sorry first one failed for some reason)

[andrewryno]

Related: #17184

I think that the intentional non-RTL was for the old button. Doesn't seem like they added that line during the redesign.

[ocean90]

Do we really need a new image? I think the padding is enough.

Also, when submitting patches, only include the .dev versions of css and js files, the commitor will re-minify it afterwards.

[jkudish]

yes it was necessary because otherwise the rest of the sprite shows up.

thanks for the tip with .dev versions, didn't know about that one. Is there a way to tell WP to load those up instead of the minified versions when testing?

[ocean90]

Just add define('SCRIPT_DEBUG', true); to your wp-config file.

Oh, didn't know that it's a sprite, is the hand cursor be used? I don't think so.

[jkudish]

Thanks for the little define, didn't know about that one :)

I don't think it's used anymore anywhere. It may be a good idea to just change that image and it be universal (not just RTL)

[yoavf]

This is actually a defect not an enhancement. I have no idea what I was thinking when didn't RTLize the press-this button in the previous release.
Anyway - attaching a refreshed and more complete patch - no need for a new image.

[downloadbook]

Nothing.

[azaozz]

In [19080]:

RTL fixes for 3.3, props yoavf SergeyBiryukov rosshanney, see #19042 fixes #18000, fixes #17988, fixes #19006