WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 7 years ago

Last modified 7 years ago

#18010 closed defect (bug) (fixed)

Localization of colors in TinyMCE

Reported by: pavelevap Owned by:
Milestone: 4.0 Priority: normal
Severity: trivial Version: 3.2
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

During translation we have found some small problems:

1) For color 993366 there is label "Brown", but this color is not really brown. "Red Violet" or "Violet" is much better, I guess. Patch attached.

2) There are 40 colors translated in TinyMCE font color picker, but when you open new window "More colors", tab "Named" - labels are not translated here. Some of these colors are translated, but not shown. Source file is wp-includes/js/tinymce/themes/advanced/js/color-picker.js.

Attachments (2)

brown_color.patch (559 bytes) - added by pavelevap 10 years ago.
ticket-18010.patch (641 bytes) - added by hebbet 10 years ago.
updated with correct path

Download all attachments as: .zip

Change History (12)

@hebbet
10 years ago

updated with correct path

#1 @hebbet
10 years ago

  • Keywords has-patch added
  • Severity changed from normal to trivial

added patch with full path

#2 follow-up: @pavelevap
10 years ago

OK, thank you. Also, maybe capital letters should be unified, see "Navy Blue" (both capital letters) and "Royal blue" (first capital, second small). And many others...

Oh, now I found that "Brown" is also label for Violet color in current standalone TinyMCE...

#3 in reply to: ↑ 2 @azaozz
10 years ago

Replying to pavelevap:

Oh, now I found that "Brown" is also label for Violet color in current standalone TinyMCE...

Yes, the matching of color names to actual colors come from TinyMCE. I'll forward this to their dev. team.

#4 @nacin
9 years ago

  • Component changed from I18N to TinyMCE

#5 @azaozz
9 years ago

Seems the color names and values (hex) are a subset of the HTML safe colors. Not sure where the names come from.

These are shown in the "select color" mini-picker that opens when clicking on a split button. Perhaps it would be better to not translate these (couldn't find official names for them) and show the hex codes on hovering over this palette.

The actual color picker opens when clicking "More Colors..." in that mini-picker and contains a Named Colors tab where the names are not translated as they may be used literally.

#6 @SergeyBiryukov
9 years ago

#23354 was marked as a duplicate.

#7 @iseulde
7 years ago

(2) is no longer relevant with TinyMCE 4.0.
But the name for #993366 is still brown. I've submitted a patch for TinyMCE.

Leaving this open until it's fixed there.

#8 @iseulde
7 years ago

Fixed in TinyMCE. Leaving open until it's updated in core.

#9 @iseulde
7 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Fixed in [28568]. https://core.trac.wordpress.org/changeset/28568#file9

Could someone mark this as "fixed" instead of "invalid"?

#10 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.0
  • Resolution changed from invalid to fixed
Note: See TracTickets for help on using tickets.