Underscores not valid in CSS class/id names

[dougal]

We're generating class names like "current_page_item", which are invalid in CSS. The underscores should be replaced with dashes.

I'm flagging this for version 1.6, but this is present in the 1.5 codebase, too. So if we do another 1.5 point release (unlikely, though I know we considered it), we might as well patch it there, too.

[markjaquith]

List of all underscored class/id names

[markjaquith]

underscores.txt was generated with this command:

$ grep -iRoE '(id|class)="[a-z]*_[a-z]*"' * | grep -o '".*"' | replace '"' '' | sort | uniq > underscores.txt

[link92]

That doesn't give me any errors under either the XHTML or CSS validator.

[link92]

​http://developer.mozilla.org/en/docs/Underscores_in_class_and_ID_Names

Seems it's recommended not to use underscores.

[dougal]

I wasn't aware that underscores were made valid in the errata. So I guess they're technically legal now. Considering the effort vs the impact, it may not be worth worrying about after all. Personally, I'll probably continue to use dashes in my class names, because it's a long-standing habit of mine now :)

[davidhouse]

I'd still say we should follow devmo's guidelines, if anyone feels like patching this up that would be appreciated.

[link92]

I don't have the time to work on it. I accepted it when I seemed like I had time, but, alas, I have been busy for ages.

[rob1n]

I'm going to close this as wontfix, actually. *Technically* underscores are allowed in CSS classes and ID's, and if we changed it now, we would break backwards compatibility a few times over. So it's not worth the effort.