Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#18029 closed defect (bug) (fixed)

Collapse menu in RTL mode

Reported by: ramiy Owned by: yoavf
Priority: normal Milestone: 3.2.1
Component: RTL Version: 3.2
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

When collapsing the side menu on wordpress dashboard, the content area should become wider.

It's not working on RTL dashboards, the content area is not getting wider.

Attachments (2)

18029.diff (372 bytes ) - added by rosshanney 15 years ago.
18029.2.diff (352 bytes ) - added by rosshanney 15 years ago.

Download all attachments as: .zip

Change History (16)

#1 @nacin
15 years ago

  • Milestone Awaiting Review3.2.1

#2 @ramiy
15 years ago

  • Summary Collapse menu in RTL moreCollapse menu in RTL mode

@rosshanney
15 years ago

#3 @rosshanney
15 years ago

  • Keywords has-patch added; needs-patch removed

@rosshanney
15 years ago

#4 @rosshanney
15 years ago

I believe new patch is sufficient, as admin menu cannot be collapsed without JavaScript.

#5 @ramiy
15 years ago

patch tested, not working.

#6 @rosshanney
15 years ago

Are you sure? It seems to do the trick for me. Do you have SCRIPT_DEBUG enabled (the patch is for global-rtl.dev.css, not global-rtl.css)?

#7 @ramiy
15 years ago

i tested the patch again (18029.2.diff - global-rtl.dev.css) in a different site. still not working.

#8 @nacin
15 years ago

Patch works for me. The issue is that we need to properly override the CSS changes that went into [18349].

#9 @nacin
15 years ago

In [18420]:

Fix RTL admin menu collapsing margin. props rosshanney, see #18029 for trunk.

#10 @nacin
15 years ago

In [18421]:

Fix RTL admin menu collapsing margin. props rosshanney, see #18029 for 3.2.

#11 @nacin
15 years ago

  • Severity majornormal

Leaving open for final review by azaozz. Some other things in global-rtl.css might deserve some edits.

#12 @azaozz
15 years ago

  • Resolutionfixed
  • Status newclosed

In [18428]:

Fix expanding the admin menu in RTL mode when no JS and collapsing it when JS, fixes #18029 for trunk

#13 @azaozz
15 years ago

In [18429]:

Fix expanding the admin menu in RTL mode when no JS and collapsing it when JS, fixes #18029 for 3.2

#14 @SergeyBiryukov
15 years ago

  • Keywords rtl-feedback removed
Note: See TracTickets for help on using tickets.