Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 3 months ago

#1804 closed enhancement (wontfix)

Reduce Kubrick custom header queries to one

Reported by: skeltoac Owned by: markjaquith
Milestone: Priority: high
Severity: normal Version: 1.6
Component: Administration Keywords: kubrick bg|has-patch bg|squashed bg|commit has-patch
Focuses: Cc:

Description

All Kubrick settings are saved as an array in a single option. Custom functions handle caching and updating. Reduces queries by about 3 per Kubrick page load. Automatically upgrades old-style options on first page load.

Attachments (1)

functions.php.diff (4.5 KB) - added by skeltoac 16 years ago.

Download all attachments as: .zip

Change History (11)

#1 @davidhouse
16 years ago

Won't these be preloaded into the options cache anyway? So there won't be extra queries...

#2 @markjaquith
16 years ago

  • Keywords bg|has-patch added

sounds good to me...

#3 @markjaquith
16 years ago

  • Keywords bg|squashed bg|commit added
  • Owner changed from matt to markjaquith
  • Status changed from new to assigned

tested, seems to work. passing up the ladder.

#4 @markjaquith
16 years ago

Important note this is /wp-content/themes/default/functions.php NOT /wp-includes/functions.php !! (that confused me at first)

#5 @matt
16 years ago

  • Resolution set to wontfix
  • Status changed from assigned to closed

No need to fix now that options are better. Also not backwards compat.

#6 @(none)
15 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

This ticket was mentioned in PR #1827 on WordPress/wordpress-develop by youknowriad.


3 months ago

  • Keywords has-patch added

This is a subpart of #1804

It's an attempt to try a patch that only contains the minimum required changes for the packages update which should hopefully unblock other patches (FSE infrastructure for instance).

#8 @prbot
3 months ago

youknowriad commented on PR #1827:

This is lacking two things to be ready to merge:

  • The default-editor-styles.css is required for the tests to pass without errors, this file comes with a npm run build but php tests right now are run without the build step. We could account for this in the runtime code but it sounds weird to adapt runtime code to tests.
  • The source map error when running npm run build. I'm not sure about this error, we could potentially ignore the failing file for now but I wonder if it highlights a bug in Gutenberg itself and whether we should have a similar check in the plugin as well.

#9 @prbot
3 months ago

noisysocks commented on PR #1827:

It's an attempt to try a patch that only contains the minimum required changes for the packages update which should hopefully unblock other patches (FSE infrastructure for instance).

Good idea 🙂

The default-editor-styles.css is required for the tests to pass without errors, this file comes with a npm run build but php tests right now are run without the build step. We could account for this in the runtime code but it sounds weird to adapt runtime code to tests.

I don't think it's wrong to add a runtime check. We need to support running WordPress from the src directory with no build files.

The source map error when running npm run build. I'm not sure about this error, we could potentially ignore the failing file for now but I wonder if it highlights a bug in Gutenberg itself and whether we should have a similar check in the plugin as well.

Also not sure about this. Let's leave it commented out in Gruntfile.js. I'll make a note to come back to this. Probably you are right that there's a bug in Gutenberg's build config.

#10 @prbot
3 months ago

desrosj commented on PR #1827:

I've changed the base of this PR to trunk. This is now the default branch going forward. See the original proposal that is finally being put in place.

Note: See TracTickets for help on using tickets.