Reduce Kubrick custom header queries to one

[skeltoac]

All Kubrick settings are saved as an array in a single option. Custom functions handle caching and updating. Reduces queries by about 3 per Kubrick page load. Automatically upgrades old-style options on first page load.

[davidhouse]

Won't these be preloaded into the options cache anyway? So there won't be extra queries...

[markjaquith]

sounds good to me...

[markjaquith]

tested, seems to work. passing up the ladder.

[markjaquith]

Important note this is /wp-content/themes/default/functions.php NOT /wp-includes/functions.php !! (that confused me at first)

[matt]

No need to fix now that options are better. Also not backwards compat.

[(none)]

Milestone 2.0 deleted

This is a subpart of #1804

It's an attempt to try a patch that only contains the minimum required changes for the packages update which should hopefully unblock other patches (FSE infrastructure for instance).

This is lacking two things to be ready to merge:

• The default-editor-styles.css is required for the tests to pass without errors, this file comes with a npm run build but php tests right now are run without the build step. We could account for this in the runtime code but it sounds weird to adapt runtime code to tests.
• The source map error when running npm run build. I'm not sure about this error, we could potentially ignore the failing file for now but I wonder if it highlights a bug in Gutenberg itself and whether we should have a similar check in the plugin as well.

It's an attempt to try a patch that only contains the minimum required changes for the packages update which should hopefully unblock other patches (FSE infrastructure for instance).

Good idea 🙂

The default-editor-styles.css is required for the tests to pass without errors, this file comes with a npm run build but php tests right now are run without the build step. We could account for this in the runtime code but it sounds weird to adapt runtime code to tests.

I don't think it's wrong to add a runtime check. We need to support running WordPress from the src directory with no build files.

The source map error when running npm run build. I'm not sure about this error, we could potentially ignore the failing file for now but I wonder if it highlights a bug in Gutenberg itself and whether we should have a similar check in the plugin as well.

Also not sure about this. Let's leave it commented out in Gruntfile.js. I'll make a note to come back to this. Probably you are right that there's a bug in Gutenberg's build config.

I've changed the base of this PR to trunk. This is now the default branch going forward. See the ​original proposal that is finally being put in place.