WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #18043, comment 17


Ignore:
Timestamp:
01/05/13 00:15:17 (16 months ago)
Author:
v-media
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18043, comment 17

    initial v1  
    1 I checked your patch, and I would say, this will result in an unknown file-size. I don't think it's a good idea, especially if we speak about large files. The better solution could be some refactoring of ms-files.php and checking for 304 before you send Content-Length. This will allow sending Content-Length only for 200. I can't provide you a patch since this doesn't seem to be a quick change. 
     1I checked your patch, and I would say, this will result in an unknown file-size. I don't think it's a good idea, especially if we speak about large files. The better solution could be some refactoring of ms-files.php and checking for 304 before you send Content-Length. This will allow sending Content-Length only for 200. I can't provide you a patch since this doesn't seem to be a quick change, but hope you agree that the idea is right. 
    22 
    33The other problem with such a patch is that someone later can add these lines again, since users will eventually ask to send the Content-Length and there will be no obvious reason why not to do it.