WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#18047 closed enhancement (fixed)

Add edit link to confirmation page for new network site

Reported by: vegasgeek Owned by: PeteMall
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Network Admin Keywords: has-patch commit
Focuses: multisite Cc:

Description

Screen: Network Admin -> Sites -> Add New

After completing the form to create a new site on a network install, I think it would be handy to have an "Edit new site" link that takes the admin directly to /network/site-info.php?id=[NewSiteID]

Attachments (2)

18047.patch (1.2 KB) - added by vegasgeek 9 years ago.
18047.2.patch (1.3 KB) - added by SergeyBiryukov 9 years ago.

Download all attachments as: .zip

Change History (9)

@vegasgeek
9 years ago

#2 @vegasgeek
9 years ago

  • Keywords has-patch added

Based on SergeyBiryukov's patch for #17313, I added an additional link directly to the edit site page.

#3 @nacin
9 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to PeteMall
  • Status changed from new to assigned
  • Type changed from feature request to enhancement

+1. $_GETsite_id? will need absint() before going directly into a URL parameter. XSS hole otherwise.

Probably fine as id rather than site_id.

The 'or' isn't translatable. Probably better to do this:

sprintf( __( 'Site added. <a href="%1$s">Visit Dashboard</a> or <a href="%2$s">Edit Site</a>' ), first link, second link )

#4 follow-up: @SergeyBiryukov
9 years ago

18047.2.patch includes the suggestions.

#5 in reply to: ↑ 4 @vegasgeek
9 years ago

Replying to SergeyBiryukov:

18047.2.patch includes the suggestions.

I tested this locally and it works like a charm. Thanks, Nacin/Sergey!

#6 @nacin
9 years ago

  • Keywords commit added

I'd feel more comfortable with $_GET['site_id'] being absint()'d before going into get_admin_url().

Since site_id is often referring to the network rather than the blog, I'd rather see this be just "id."

#7 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [18750]:

Add 'Visit Dashboard' and 'Edit Site' links to the site added message on site-new.php. props vegasgeek, SergeyBiryukov. fixes #18047. fixes #17313.

Note: See TracTickets for help on using tickets.