WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 2 years ago

#18057 closed enhancement (wontfix)

Twenty Eleven: display featured images on pages even if they are too small for header

Reported by: murky Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.2
Component: Bundled Theme Keywords: has-patch close
Focuses: Cc:

Description

With twentyeleven, if there is a featured image, it takes the place of the header.... if it's big enough.

A smaller featured image is, as far as I can see, ignored. This caused much consternation due to the conflict with twentyeleven using featured images, but not having them appear.

There should be code which says 'if featured image is big enough, use it on the single page header' (as now)

BUT ALSO: 'If the image is SMALLER than this, use it as a featured image on summary pages'

Ideally: If the top post on a summary page has a featured image big enough to use in the header, use it there, too.

Change History (10)

comment:1 @duck_4 years ago

#18027 #13671 #14898

I think there should probably be some way of a theme adding text to the featured image metabox giving the required image size.

comment:3 @nacin4 years ago

  • Keywords has-patch 3.4-early added
  • Milestone changed from Awaiting Review to Future Release

Looks like the patches on #18057 should work here.

Version 0, edited 4 years ago by nacin (next)

comment:4 @lancewillett2 years ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-refresh added; 3.4-early removed
  • Milestone changed from Future Release to 3.6

Needs a refresh and testing, we can get this into 3.6.

comment:5 follow-up: @lancewillett2 years ago

  • Keywords 2nd-opinion added
  • Summary changed from TwentyEleven - meeting expectations for featured images to Twenty Eleven: display featured images on pages even if they are too small for header

I'm also open to opinions on "wontfixing" this -- if featured images all of a sudden appear on thousands of blogs, that could be considered "broken" and not a good user experience.

Might have to chalk it up to "learn for the future" and leave as-is.

comment:6 @murky2 years ago

Although, how many featured images would be used if there was no obvious result in using them? For users like this, there'd be no effect as no featured image will have been chosen....

(Though given its now 2013, I could see that TwentyEleven theme may not be priority :)

comment:7 @lancewillett2 years ago

We'd like to continue improving Ten, Eleven, and Twelve as we go along. That's fine, if something makes sense we'll fix it.

But, I'm asking if it's a good improvement or not.

comment:8 @murky2 years ago

I can see your concern about making a change which has loads of images appear - but this will only happen where featured images are used (and here, the images will have been chosen, so will work).

I can see that, in many case, people will have played with featured images only to see no effect - and then stopped playing with them - for these folks, no change.

How you go with this? Entirely up to you guys.... but if it helps, the original ticket was as a result of confusion arising from spending time with featured images not behaving as it seemed they should.

comment:9 in reply to: ↑ 5 @DrewAPicture2 years ago

  • Keywords close added; 2nd-opinion removed

Replying to lancewillett:

... if featured images all of a sudden appear on thousands of blogs, that could be considered "broken" and not a good user experience.

Might have to chalk it up to "learn for the future" and leave as-is.

I vote wontfix. The theme has been out for some time now and there is an expected result if the featured image isn't big enough. A change like this could easily be construed as "this is broken, it didn't work like this before."

comment:10 @lancewillett2 years ago

  • Keywords needs-refresh removed
  • Milestone 3.6 deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.