WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 6 years ago

#18060 closed defect (bug) (wontfix)

image upload handling between atompub and xmlrpc different

Reported by: rfc1437 Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.2
Component: AtomPub Keywords: has-patch needs-testing
Focuses: Cc:
PR Number:

Description

Uploading images via XMLRPC generates different image sizes in addition to the original image. Uploading the same image through AtomPub will only create a single original file in the uploads/year/month/ directory, the thumbnail and different formats normally generated on upload are missing. It is probably because wp_handle_upload is missing from the wp-app.php create_attachment definiition - it only uploads the bits and creates an attachment, but neither handles metadata updates nor image thumbnail generation.

Attachments (2)

18060.diff (1.3 KB) - added by kawauso 8 years ago.
18060-0304.diff (1.3 KB) - added by rfc1437 7 years ago.
fixed patch for 3.4

Download all attachments as: .zip

Change History (8)

#1 @kawauso
8 years ago

  • Keywords has-patch needs-testing added

The AtomPub code looks rather unloved, following patch brings it more in line with media_handle_upload() and adds image exif/iptc data checks and metadata updates and sizes.

I haven't got an AtomPub client to test with though.

@kawauso
8 years ago

#2 @rfc1437
8 years ago

Ok, I tested it on my blog with the only AtomPub client I have at hand - the LR/Blog plugin for Lightroom - and it worked now. Since this was the AtomPub client I noticed the problem with, I'd say this patch should do it :) Thanks!

#3 @rfc1437
7 years ago

  • Cc gb@… added
  • Version changed from 3.2 to 3.4

This is annoying: it still is not fixed with 3.4 and the patch doesn't work anymore now, because the file structure did change. Does anybody ever actually read and work on these tickets?

@rfc1437
7 years ago

fixed patch for 3.4

#4 @rfc1437
7 years ago

I updated the patch to work with 3.4 - to repeat, the problem isn't missing metadata or anything, the problem is missing image sizes that are normally generated on upload.

#5 @SergeyBiryukov
7 years ago

  • Component changed from Media to AtomPub
  • Version changed from 3.4 to 3.2

Version number indicates when the bug was initially introduced/reported.

#6 @nacin
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As AtomPub was removed from core in 2012, see #21866. There is a plugin for it here: http://wordpress.org/plugins/atom-publishing-protocol/.

I doubt anyone really interfaces with WordPress via AtomPub anymore. Did anyone ever truly use it? I heard that when WordPress.com had it enabled, a few dozen posts came through it a day, all from few clients.

So realistically, AtomPub is essentially considered "end of life" to us. This plugin was merely done for backwards compatibility.

Closing this ticket as wontfix.

Note: See TracTickets for help on using tickets.