WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#18084 reopened enhancement

Comments Page Rewrite Customization

Reported by: webord Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.2
Component: Rewrite Rules Keywords: has-patch
Focuses: Cc:

Description

So I was doing some stuff on translation of the rewrite URLs, to pt-BR I've run into a problem, that the Comments Page Rules cannot be changed using a base variable, like all the other bases.

So Im attaching a file to this ticket with the modified File, but I didn't test if its a good solution, thats the one I can think of.

I really would like to see this enchancement.

Thanks,

Attachments (3)

rewrite.php (57.6 KB) - added by webord 3 years ago.
New Rewrite File
rewrite.2.php (57.6 KB) - added by webord 3 years ago.
New Rewrite File
18084.patch (877 bytes) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (9)

webord3 years ago

New Rewrite File

webord3 years ago

New Rewrite File

comment:1 webord3 years ago

Sorry for the double file...

comment:2 webord3 years ago

  • Version set to 3.2

comment:3 scribu2 years ago

  • Keywords 2nd-opinion needs-testing removed

Would be a lot easier to review if you submitted this as a diff.

comment:4 webord2 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Yes, I didn't know about .diff files at the time. And now I dont really remember what I've changed.

comment:5 helenyhou2 years ago

  • Milestone Awaiting Review deleted

SergeyBiryukov2 years ago

comment:6 SergeyBiryukov2 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone set to Awaiting Review
  • Resolution invalid deleted
  • Status changed from closed to reopened

18084.patch contains the changes from rewrite.php.

Note: See TracTickets for help on using tickets.