Comments Page Rewrite Customization

[webord]

So I was doing some stuff on translation of the rewrite URLs, to pt-BR I've run into a problem, that the Comments Page Rules cannot be changed using a base variable, like all the other bases.

So Im attaching a file to this ticket with the modified File, but I didn't test if its a good solution, thats the one I can think of.

I really would like to see this enchancement.

Thanks,

[webord]

New Rewrite File

[webord]

New Rewrite File

[webord]

Sorry for the double file...

[scribu]

Would be a lot easier to review if you submitted this as a diff.

[webord]

Yes, I didn't know about .diff files at the time. And now I dont really remember what I've changed.

[SergeyBiryukov]

18084.patch​ contains the changes from rewrite.php​.

[chriscct7]

Duplicate of (and implemented in) #12507

[SergeyBiryukov]

Comment pagination base is still hardcoded, #12507 did not affect it.

[chriscct7]

@sergeybiryukov This is the changeset for that trac ticket which I believe to be a duplicate (I could be wrong though): [15582]

Note the changes made for rewrite.php are the same as the proposed changes in the #18084 patch but just with different variable names.

[SergeyBiryukov]

The changes are different. The patch here was created after that changeset, not before.

[15582] replaced page with $this->pagination_base in $pageregex.

18084.patch​ replaces comment-page with $this->comments_pagination_base in the next line.

[chriscct7]

Ah, indeed you are correct sir. My apologies.

The proposed patch look good to go, but whoever merges it will want to update the @since on the new object parameter (as it's currently set to 3.5 and the earliest it could be in core would be 4.1).

[johnbillion]

18084.2.patch​ replaces hardcoded usage of comment-page with the comment pagination base.

[iseulde]

has-patch 4.2-early so moving to 4.2.

[SergeyBiryukov]

In 31459:

Replace hardcoded usage of comment-page with the comment pagination base.

props johnbillion, SergeyBiryukov, webord.
fixes #18084.

[SergeyBiryukov]

#27631 was marked as a duplicate.