Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#18091 closed defect (bug) (fixed)

Collapsed menu cannot be restored

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: azaozz's profile azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 2.8
Component: UI Keywords: has-patch
Focuses: Cc:

Description

  1. Set up a clean WP installation and log in.
  2. Collapse menu.
  3. Reload the page.
  4. Uncollapse menu.
  5. Reload the page.
  6. The menu will stay collapsed.

I've tracked this down to wp_user_settings(). If a current cookie is empty (as on new installation after uncollapsing menu), it will not be saved.

Attachments (2)

18091.patch (1.3 KB) - added by SergeyBiryukov 13 years ago.
18091.2.patch (429 bytes) - added by SergeyBiryukov 13 years ago.

Download all attachments as: .zip

Change History (15)

#1 @nacin
13 years ago

  • Milestone changed from Awaiting Review to 3.2.2

Hmm. Surprised this didn't occur on 3.1 then?

#2 @SergeyBiryukov
13 years ago

  • Version changed from 3.2.1 to 2.8

This was introduced in [11118] and appeared in 2.8. Before that, mfold wasn't deleted from cookie, and it wasn't empty.

#3 @dalesaurus
13 years ago

You must check your browser cookies for an entry with mfold. This gets re-saved on admin page loads and logging out to the wp_usermeta table, key is wp_user-settings.

Manual fix via SQL:

  1. Log out, clear browser cookies
  2. Use SQL client to find entries:
    SELECT * FROM wp_usermeta WHERE meta_value LIKE '%mfold%';
    
    +----------+---------+------------------+------------+
    | umeta_id | user_id | meta_key         | meta_value |
    +----------+---------+------------------+------------+
    |     1152 |       4 | wp_user-settings | mfold=f    |
    +----------+---------+------------------+------------+
    
  3. Delete offending entries
    DELETE FROM wp_usermeta WHERE umeta_id = 1152;
    

#4 @SergeyBiryukov
13 years ago

Yeah, but that's just a workaround.

#5 @Eric3D
13 years ago

It appears this bug is still present in 3.3 beta 1. The SQL manual fix worked.

#6 @SergeyBiryukov
13 years ago

Per IRC discussion, 18091.2.patch uses setUserSetting('mfold', 'o').

#7 @azaozz
13 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19091]:

Fix menu folding on new installs, props SergeyBiryukov, fixes #18091

#8 @azaozz
13 years ago

  • Milestone changed from 3.2.2 to 3.3

#9 follow-up: @daankortenbach
12 years ago

  • Version 2.8 deleted

I'm having this issue on 3.5 on multiple sites. Tested on in FF and Chrome.

#10 in reply to: ↑ 9 @bpetty
12 years ago

  • Version set to 2.8

Replying to daankortenbach:

I'm having this issue on 3.5 on multiple sites. Tested on in FF and Chrome.

Could you please open a new ticket for this and provide some additional details? For example, it would be helpful to know if you see any javascript errors in the console, and also if you have any plugins installed as they could interfere with this.

This ticket was confirmed and fixed, meaning your issue is likely not the same as this was.

#11 @TakeoK
12 years ago

I'm having this issue as well. Very annoying.

  • Clean install of WordPress 3.5
  • No plugins
  • No themes (other than 2012 and 2011)
  • Safari 6.0.2
  • Mac OS 10.8.2

The cookie "wp-settings-1" keeps getting set to "fold%3Df" no matter how many times I delete the cookies, quit the browser, etc.

Version 0, edited 12 years ago by TakeoK (next)

#12 @adamsilverstein
12 years ago

  • Cc adamsilverstein@… added
Note: See TracTickets for help on using tickets.