WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 19 months ago

#18091 closed defect (bug) (fixed)

Collapsed menu cannot be restored

Reported by: SergeyBiryukov Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 2.8
Component: UI Keywords: has-patch
Focuses: Cc:

Description

  1. Set up a clean WP installation and log in.
  2. Collapse menu.
  3. Reload the page.
  4. Uncollapse menu.
  5. Reload the page.
  6. The menu will stay collapsed.

I've tracked this down to wp_user_settings(). If a current cookie is empty (as on new installation after uncollapsing menu), it will not be saved.

Attachments (2)

18091.patch (1.3 KB) - added by SergeyBiryukov 4 years ago.
18091.2.patch (429 bytes) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (15)

@SergeyBiryukov4 years ago

comment:1 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.2.2

Hmm. Surprised this didn't occur on 3.1 then?

comment:2 @SergeyBiryukov4 years ago

  • Version changed from 3.2.1 to 2.8

This was introduced in [11118] and appeared in 2.8. Before that, mfold wasn't deleted from cookie, and it wasn't empty.

comment:3 @dalesaurus4 years ago

You must check your browser cookies for an entry with mfold. This gets re-saved on admin page loads and logging out to the wp_usermeta table, key is wp_user-settings.

Manual fix via SQL:

  1. Log out, clear browser cookies
  2. Use SQL client to find entries:
    SELECT * FROM wp_usermeta WHERE meta_value LIKE '%mfold%';
    
    +----------+---------+------------------+------------+
    | umeta_id | user_id | meta_key         | meta_value |
    +----------+---------+------------------+------------+
    |     1152 |       4 | wp_user-settings | mfold=f    |
    +----------+---------+------------------+------------+
    
  3. Delete offending entries
    DELETE FROM wp_usermeta WHERE umeta_id = 1152;
    

comment:4 @SergeyBiryukov4 years ago

Yeah, but that's just a workaround.

comment:5 @Eric3D3 years ago

It appears this bug is still present in 3.3 beta 1. The SQL manual fix worked.

@SergeyBiryukov3 years ago

comment:6 @SergeyBiryukov3 years ago

Per IRC discussion, 18091.2.patch uses setUserSetting('mfold', 'o').

comment:7 @azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19091]:

Fix menu folding on new installs, props SergeyBiryukov, fixes #18091

comment:8 @azaozz3 years ago

  • Milestone changed from 3.2.2 to 3.3

comment:9 follow-up: @daankortenbach2 years ago

  • Version 2.8 deleted

I'm having this issue on 3.5 on multiple sites. Tested on in FF and Chrome.

comment:10 in reply to: ↑ 9 @bpetty2 years ago

  • Version set to 2.8

Replying to daankortenbach:

I'm having this issue on 3.5 on multiple sites. Tested on in FF and Chrome.

Could you please open a new ticket for this and provide some additional details? For example, it would be helpful to know if you see any javascript errors in the console, and also if you have any plugins installed as they could interfere with this.

This ticket was confirmed and fixed, meaning your issue is likely not the same as this was.

comment:11 @TakeoK2 years ago

I'm having this issue as well. Very annoying.

  • Clean install of WordPress 3.5
  • No plugins
  • No themes (other than 2012 and 2011)
  • Safari 6.0.2
  • Mac OS 10.8.2

The cookie "wp-settings-1" keeps getting set to "fold%3Df" no matter how many times I delete the cookies, quit the browser, etc.

Version 0, edited 2 years ago by TakeoK (next)

comment:12 @adamsilverstein2 years ago

  • Cc adamsilverstein@… added
Note: See TracTickets for help on using tickets.