WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#18096 closed defect (bug) (fixed)

Localization context for All Links

Reported by: pavelevap Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

String "All Links" is used on several places, but in some languages there are several meanings (see attached patch):

  • "All Links" in left admin menu (submenu) is about listing links. Also other submenus have unique strings for better handling in menu.
  • "All Links" in Links widget is much more about counting link items (like "all of them").

In Links widget there are two places with the same string, but I could not simulate to display one of them on my testing website?

if ( is_admin() && !$category ) {
	// Display All Links widget as such in the widgets screen
	echo $before_widget . $before_title. __('All Links') . $after_title . $after_widget;
	return;
}

This situation will never happen?

And one more question - is it possible to uncheck categories for selected link (to make link without any attached link category)? I tried to uncheck category checkbox and it did not work (after saving was category to this link restored). I am not sure if it is feature or bug?

Attachments (3)

all_links_context.patch (1.9 KB) - added by pavelevap 3 years ago.
18096.patch (2.2 KB) - added by SergeyBiryukov 3 years ago.
18096.2.patch (1.9 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 kawauso3 years ago

  • Keywords has-patch added

comment:2 ramiy3 years ago

In RTL, the "left admin menu" will be "right admin menu". You better change this to "admin menu".

SergeyBiryukov3 years ago

comment:3 SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.3

Replying to pavelevap:

In Links widget there are two places with the same string, but I could not simulate to display one of them on my testing website?

That part was introduced in [10896] as a fix for #9449. It doesn't make much sense, since the function is never called in the admin, unless I'm missing something. So I removed it in my patch.

Replying to ramiy:

In RTL, the "left admin menu" will be "right admin menu". You better change this to "admin menu".

Done in 18096.patch.

comment:4 follow-up: nacin2 years ago

Let's save [10896] reversion for another ticket.

comment:5 nacin2 years ago

  • Keywords commit added

SergeyBiryukov2 years ago

comment:6 in reply to: ↑ 4 SergeyBiryukov2 years ago

Refreshed the patch.

Replying to nacin:

Let's save [10896] reversion for another ticket.

#19179

comment:7 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19202]:

Context for 'All Links'. props SergeyBiryukov, pavelevap. fixes #18096.

Note: See TracTickets for help on using tickets.