Localization context for All Links

[pavelevap]

String "All Links" is used on several places, but in some languages there are several meanings (see attached patch):

• "All Links" in left admin menu (submenu) is about listing links. Also other submenus have unique strings for better handling in menu.
• "All Links" in Links widget is much more about counting link items (like "all of them").

In Links widget there are two places with the same string, but I could not simulate to display one of them on my testing website?

if ( is_admin() && !$category ) {
	// Display All Links widget as such in the widgets screen
	echo $before_widget . $before_title. __('All Links') . $after_title . $after_widget;
	return;
}

This situation will never happen?

And one more question - is it possible to uncheck categories for selected link (to make link without any attached link category)? I tried to uncheck category checkbox and it did not work (after saving was category to this link restored). I am not sure if it is feature or bug?

[ramiy]

In RTL, the "left admin menu" will be "right admin menu". You better change this to "admin menu".

[SergeyBiryukov]

Replying to pavelevap:

In Links widget there are two places with the same string, but I could not simulate to display one of them on my testing website?

That part was introduced in [10896] as a fix for #9449. It doesn't make much sense, since the function is never called in the admin, unless I'm missing something. So I removed it in my patch.

Replying to ramiy:

In RTL, the "left admin menu" will be "right admin menu". You better change this to "admin menu".

Done in 18096.patch​.

[nacin]

Let's save [10896] reversion for another ticket.

[SergeyBiryukov]

Refreshed the patch.

Replying to nacin:

Let's save [10896] reversion for another ticket.

#19179

[nacin]

In [19202]:

Context for 'All Links'. props SergeyBiryukov, pavelevap. fixes #18096.