WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 8 months ago

#18097 reopened defect (bug)

Themes update-check should check parent/child

Reported by: nacin Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: WordPress.org site Keywords:
Focuses: Cc:

Description

A child theme by the name of Commune gets served the updates of a parent theme.

We should only serve an update to a theme if it's a child or parent, appropriately. For child themes, we should also confirm the parent.

Change History (4)

comment:1 dd323 years ago

Closed #18147 as duplicate of this.

comment:2 navjotjsingh3 years ago

  • Cc navjotjsingh@… added

comment:3 follow-up: Otto428 months ago

  • Milestone WordPress.org deleted
  • Resolution set to wontfix
  • Status changed from new to closed

This is a generic problem with naming, not specific to child/parent themes. When you make your custom theme, I recommend choosing a name unique to the site, like "Example.com-themename" or what have you.

comment:4 in reply to: ↑ 3 nacin8 months ago

  • Milestone set to WordPress.org
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Replying to Otto42:

This is a generic problem with naming, not specific to child/parent themes. When you make your custom theme, I recommend choosing a name unique to the site, like "Example.com-themename" or what have you.

Correct, but a sanity check on the parent/child situation of the theme is an additional way for us to know if we have the right theme.

It's entirely possible that a theme switches to a different parent or child at one point, but I don't think the theme directory can or should support that ever, and thus this would be a safe check.

Note: See TracTickets for help on using tickets.