WordPress.org

Make WordPress Core

Opened 7 years ago

Last modified 3 years ago

#18097 reopened defect (bug)

Themes update-check should check parent/child

Reported by: nacin Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: WordPress.org site Keywords: needs-patch
Focuses: Cc:

Description

A child theme by the name of Commune gets served the updates of a parent theme.

We should only serve an update to a theme if it's a child or parent, appropriately. For child themes, we should also confirm the parent.

Change History (5)

#1 @dd32
7 years ago

Closed #18147 as duplicate of this.

#2 @navjotjsingh
7 years ago

  • Cc navjotjsingh@… added

#3 follow-up: @Otto42
5 years ago

  • Milestone WordPress.org deleted
  • Resolution set to wontfix
  • Status changed from new to closed

This is a generic problem with naming, not specific to child/parent themes. When you make your custom theme, I recommend choosing a name unique to the site, like "Example.com-themename" or what have you.

#4 in reply to: ↑ 3 @nacin
5 years ago

  • Milestone set to WordPress.org
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Replying to Otto42:

This is a generic problem with naming, not specific to child/parent themes. When you make your custom theme, I recommend choosing a name unique to the site, like "Example.com-themename" or what have you.

Correct, but a sanity check on the parent/child situation of the theme is an additional way for us to know if we have the right theme.

It's entirely possible that a theme switches to a different parent or child at one point, but I don't think the theme directory can or should support that ever, and thus this would be a safe check.

#5 @chriscct7
3 years ago

  • Keywords needs-patch added
Note: See TracTickets for help on using tickets.