WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#18119 closed defect (bug) (fixed)

get_space_allowed ignores option set to 0

Reported by: jakubtyrcha's profile jakub.tyrcha Owned by: markjaquith's profile markjaquith
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Multisite Keywords: has-patch commit
Focuses: Cc:

Description

if 'blog_upload_space' is set to 0, get_space_allowed() uses get_site_option instead of accepting a "0" value.

See unit tests:
​http://gsoc.svn.wordpress.org/2011/jakub.tyrcha/test_wpms.php

Attachments (1)

18119.patch​ (523 bytes) - added by jakub.tyrcha 13 years ago.

Download all attachments as: .zip

Change History (6)

@jakub.tyrcha
13 years ago

#1 @hakre
13 years ago

Nice catch.

#2 @SergeyBiryukov
13 years ago

  • Milestone changed from Awaiting Review to 3.3

#3 @nacin
13 years ago

  • Keywords commit added

Looks good to me.

#4 @markjaquith
13 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In [19314]:

Only fall back to get_site_option() if blog_upload_space value is === false. Zero should not fall back. fixes #18119. props jakub.tyrcha

This ticket was mentioned in ​Slack in #core by jeremyfelt. ​View the logs.
10 years ago

Note: See TracTickets for help on using tickets.