Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#18125 closed defect (bug) (fixed)

Consistency for normal TinyMCE and DFW translation

Reported by: pavelevap Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2.1
Component: I18N Keywords: has-patch commit
Focuses: Cc:


There are different strings for the same buttons in standard visual editor and DFW mode. They differ due to added shortcuts to DFW strings.

Please see attached patch which removes 9 strings by unifying them. I chose to add shortcuts to translatable strings (there are not only english letters in some languages), but it can be also done reversely. I also changed some small inconsistencies (spaces between keyboard keys, etc). Also Alt+Shift+B (and I) does not work for me, so I removed them.

Main result of this patch: 9 removed similar strings = happier translators + less memory for using translation files.

Attachments (2)

dfw_tinymce_strings.patch (5.9 KB) - added by pavelevap 4 years ago.
18125.patch (5.9 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 @pavelevap4 years ago

Another related ticket (not needed TinyMCE strings) is here: http://core.trac.wordpress.org/ticket/16638

comment:2 @SergeyBiryukov4 years ago

  • Keywords has-patch added

comment:3 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.3

comment:4 @nacin3 years ago

  • Keywords commit added

All this does is merge strings? Okay.

comment:5 @nacin3 years ago

  • Keywords needs-refresh added

Patch doesn't apply.

@SergeyBiryukov3 years ago

comment:6 @SergeyBiryukov3 years ago

  • Keywords needs-refresh removed

comment:7 @azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19263]:

Standardize title strings for editor buttons, props pavelevap SergeyBiryukov, fixes #18125

Note: See TracTickets for help on using tickets.