WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18128 closed defect (bug) (fixed)

Remove unsupported sequential link types

Reported by: Elpie Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2.1
Component: Validation Keywords: has-patch
Focuses: Cc:

Description

All sequential link types used in WordPress, with the exception of the link rel='prev' and link rel='next' that are output by adjacent_posts_rel_link_wp_head, are unsupported by any browser or assistive device.

These were considered in the early drafts of the HTML5 spec but were officially removed last year. See: http://lists.w3.org/Archives/Public/public-html/2010Nov/0042.html

Now that the default theme shipping with WordPress is using HTML5 it makes sense to remove the unsupported link types. Leaving them in invalidates TwentyEleven and once the HTML testing tools are improved this will become obvious to users.

Recommend removing the relevant functions from link-template.php and the actions from default-filters.php

Attachments (2)

18128.diff (8.5 KB) - added by kawauso 3 years ago.
Remove 'adjacent_posts_rel_link_wp_head' action, deprecate related functions
18128.2.diff (8.6 KB) - added by kawauso 3 years ago.

Download all attachments as: .zip

Change History (12)

kawauso3 years ago

Remove 'adjacent_posts_rel_link_wp_head' action, deprecate related functions

comment:2 follow-up: kawauso3 years ago

  • Keywords has-patch added; needs-patch removed

comment:3 in reply to: ↑ 2 Elpie3 years ago

Replying to kawauso:
Umm... it needs to be the other way around ;)

All sequential link types need to be removed except adjacent_posts_rel_link_wp_head

I don't have access to svn at the moment so can't submit a patch (sorry!) but the ones to remove are:

'index_rel_link'
'parent_post_rel_link'
'start_post_rel_link'
Those are the invalid rel links.

comment:4 Elpie3 years ago

  • Keywords needs-patch added

kawauso3 years ago

comment:5 kawauso3 years ago

  • Keywords needs-patch removed

Think that should be the right ones this time :P

comment:6 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to nacin
  • Status changed from new to accepted

comment:7 nacin3 years ago

Closed #14796 as it'll be fixed by this one.

comment:8 sirzooro3 years ago

  • Cc sirzooro added

comment:9 nacin3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18680]:

Remove support for <link rel=start>, end, up, and index. These rel="" values have been dropped by the HTML Working Group. props Elpie, kawauso, fixes #18128.

comment:10 nacin3 years ago

We could probably go ahead and stub these functions as well, but I'll leave them in deprecated.php for now.

Note: See TracTickets for help on using tickets.