WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 10 months ago

#18130 closed defect (bug) (fixed)

Editing menu items - Cancel button does not work

Reported by: pavelevap Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.2.1
Component: Menus Keywords:
Focuses: Cc:

Description

When editing menu items, "Cancel" button at the bottom does not work. I can collapse menu item with top right arrow, but "Cancel" link worked also for collapsing menu items in the past. Now, after clicking on "Cancel" there is no response...

Change History (7)

comment:1 nacin3 years ago

Works for me. JS error?

comment:2 pavelevap3 years ago

Tested in IE9 and latest Firefox, does not work for me. There is no error in Firebug, but link "Cancel" does not collapse menu item.

Link leads to

http://localhost.cz/wp-admin/nav-menus.php?edit-menu-item=20861&cancel=1311059362#menu-item-settings-20861

Using latest trunk, Twenty Eleven, no plugins. Tested also on one production site and also does not work. Any idea?

comment:3 in reply to: ↑ description SergeyBiryukov3 years ago

  • Keywords reporter-feedback added

Replying to pavelevap:

"Cancel" link worked also for collapsing menu items in the past.

Not sure about that part. I've checked some versions from 3.2.1 down to 3.0 and it doesn't collapse menu items but instead resets any changes made to the item.

Could you please verify it actually used to collapse items at some point?

comment:4 SergeyBiryukov3 years ago

OTOH, looks like it doesn't restore description field, only text input fields (Firefox 5.0/Windows).

comment:5 pavelevap3 years ago

Ooops, I would expect this (collapsing menu), but I am not sure now... I think that it could work this way in the past, but not sure... I will test my old versions too...

comment:6 SergeyBiryukov3 years ago

It probably should collapse items anyway, for consistency with editing Dashboard widgets.

comment:7 DrewAPicture10 months ago

  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 3.6
  • Resolution set to fixed
  • Status changed from new to closed

This works as of [23441], see #23119.

Note: See TracTickets for help on using tickets.