WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#18143 accepted enhancement

Add size for Gallery Settings

Reported by: designsimply Owned by: nacin
Milestone: Future Release Priority: normal
Severity: normal Version: 3.2.1
Component: Gallery Keywords: westi-likes has-patch
Focuses: Cc:

Description

Add a size option for gallery settings so it's easy to insert a single column gallery with large or full size images.

Attachments (4)

add-size-to-gallery-settings.diff (2.8 KB) - added by designsimply 3 years ago.
18143.1.diff (3.5 KB) - added by designsimply 2 years ago.
Adding column update on size change.
18143-add-gallery-settings-size-field.png (238.3 KB) - added by designsimply 2 years ago.
18143.2.diff (3.7 KB) - added by designsimply 2 years ago.
Change 'Size' to 'Image size'

Download all attachments as: .zip

Change History (12)

comment:1 westi3 years ago

  • Keywords 3.3-early westi-likes added
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to westi
  • Status changed from new to accepted
  • Version set to 3.2.1

comment:2 nacin3 years ago

  • Milestone changed from Future Release to 3.3
  • Owner changed from westi to nacin

comment:3 nacin3 years ago

I thought there was a filter on Thumbnail/Medium/Large/Full in image_size_input_fields() that we could apply here, but there isn't.

comment:4 nacin3 years ago

  • Keywords ux-feedback added

Patch works, tested, looks good. +1

However, when choosing "Large" or "Full", I want to think that number of columns should be reduced from 3 to 1, and that "Medium" should reduce columns to 2. That also makes me think that Size should appear immediately above the Columns section, and thus below the order fields.

Anyone disagree? What I did was add two images as [gallery size="large"] but the theme applied certain CSS due to the three columns (which I didn't notice) and at first I couldn't figure it out. (I don't ever really use galleries, so treat me as a user here.)

comment:5 ryan3 years ago

  • Milestone changed from 3.3 to Future Release

Punting enhancements from 3.3

designsimply2 years ago

Adding column update on size change.

designsimply2 years ago

Change 'Size' to 'Image size'

comment:6 jane2 years ago

  • Keywords 3.3-early ux-feedback removed
  • Milestone changed from Future Release to 3.4

Fine by me.

comment:7 husobj2 years ago

  • Cc ben@… added

comment:8 ryan2 years ago

  • Milestone changed from 3.4 to Future Release
Note: See TracTickets for help on using tickets.