WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#18181 closed defect (bug) (fixed)

Plugin Install Thickbox gives notice

Reported by: hakre Owned by: nacin
Priority: normal Milestone: 3.3
Component: Warnings/Notices Version: 3.2.1
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

The plugin-install code introduced in [9163] does not check for propery existance prior making use of it resulting in notices if properties are not set.

That's exemplary the case with stdClass::$downloaded.

Attachments (1)

18181.diff​ (929 bytes ) - added by hakre 15 years ago.
Check for existance.

Download all attachments as: .zip

Change History (5)

@hakre
15 years ago

Check for existance.

#1 @hakre
15 years ago

  • Keywords has-patch added

The attached diff fixes the issue for me on HEAD and 3.2.1.

#2 @nacin
15 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 3.3

Let's change that to isset.

#3 @nacin
15 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In [18586]:

Check if property exists on plugins_api() returned object in install_plugin_information(). props hakre, fixes #18181.

#4 @nacin
15 years ago

I borrowed the same code from theme-install.php and decided to avoid setting keys that didn't already exist.

Note: See TracTickets for help on using tickets.