WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#18181 closed defect (bug) (fixed)

Plugin Install Thickbox gives notice

Reported by: hakre Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2.1
Component: Warnings/Notices Keywords: has-patch commit
Focuses: Cc:

Description

The plugin-install code introduced in [9163] does not check for propery existance prior making use of it resulting in notices if properties are not set.

That's exemplary the case with stdClass::$downloaded.

Attachments (1)

18181.diff (929 bytes) - added by hakre 6 years ago.
Check for existance.

Download all attachments as: .zip

Change History (5)

@hakre
6 years ago

Check for existance.

#1 @hakre
6 years ago

  • Keywords has-patch added

The attached diff fixes the issue for me on HEAD and 3.2.1.

#2 @nacin
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.3

Let's change that to isset.

#3 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18586]:

Check if property exists on plugins_api() returned object in install_plugin_information(). props hakre, fixes #18181.

#4 @nacin
6 years ago

I borrowed the same code from theme-install.php and decided to avoid setting keys that didn't already exist.

Note: See TracTickets for help on using tickets.