Make WordPress Core

Opened 15 years ago

Closed 5 years ago

#18184 closed defect (bug) (worksforme)

Wrong area is cropped when using arrow keys to adjust the position of the crop box

Reported by: danielristic Owned by: azaozz
Priority: normal Milestone:
Component: Media Version: 2.9
Severity: normal Keywords: needs-patch
Cc: Focuses: administration

Description

When using the crop tool to modify an image, if you select an area and then use the arrow keys to move it around, when you click on the crop button, the wrong area has been cropped. If you do the same thing using the mouse to move the crop box, it works well.

Attachments (1)

18184.patch​ (638 bytes ) - added by SergeyBiryukov 15 years ago.

Download all attachments as: .zip

Change History (11)

#1 @nacin
15 years ago

  • Owner set to azaozz
  • Status new → assigned
  • Version 3.2.1 → 2.9

#2 @SergeyBiryukov
15 years ago

  • Keywords has-patch added

imgAreaSelect's onSelectEnd() doesn't fire on a key press.

18184.patch​ moves setCropSelection() to onSelectChange().

#3 @SergeyBiryukov
15 years ago

  • Milestone Awaiting Review → 3.4

#4 @ryan
14 years ago

  • Milestone 3.4 → Future Release

#6 @ericlewis
12 years ago

  • Keywords close added

Keyboard shortcuts don't work at all in Chrome, and push your crop selection to the edge immediately in Firefox.

I suggest we maybelater here, and revisit this when we redo the entire image editor experience someday.

#7 follow-up: @SergeyBiryukov
12 years ago

  • Keywords close removed

Hmm, arrow keys used to work in earlier Firefox versions. I wonder if this could be a regression.

Now moving the selection with Shift + arrow keys consistently causes Firefox to crash after a few attempts. We should either fix that or disable the keys.

#8 in reply to: ↑ 7 @SergeyBiryukov
12 years ago

Replying to SergeyBiryukov:

Now moving the selection with Shift + arrow keys consistently causes Firefox to crash after a few attempts.

Also noted in ​https://make.wordpress.org/docs/2014/04/16/wordpress-3-9-codex-updates/#comment-29068.

#9 @chriscct7
11 years ago

  • Focuses administration added
  • Keywords needs-patch added; has-patch removed

#10 @azaozz
5 years ago

  • Resolution → worksforme
  • Status assigned → closed

I believe this was fixed by one of the imgAreaSelect updates.

Note: See TracTickets for help on using tickets.