WordPress.org

Make WordPress Core

Opened 8 years ago

Last modified 5 months ago

#18184 assigned defect (bug)

Wrong area is cropped when using arrow keys to adjust the position of the crop box

Reported by: danielristic Owned by: azaozz
Milestone: Priority: normal
Severity: normal Version: 2.9
Component: Media Keywords: needs-patch
Focuses: administration Cc:
PR Number:

Description

When using the crop tool to modify an image, if you select an area and then use the arrow keys to move it around, when you click on the crop button, the wrong area has been cropped. If you do the same thing using the mouse to move the crop box, it works well.

Attachments (1)

18184.patch (638 bytes) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (10)

#1 @nacin
8 years ago

  • Owner set to azaozz
  • Status changed from new to assigned
  • Version changed from 3.2.1 to 2.9

#2 @SergeyBiryukov
8 years ago

  • Keywords has-patch added

imgAreaSelect's onSelectEnd() doesn't fire on a key press.

18184.patch moves setCropSelection() to onSelectChange().

#3 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 3.4

#4 @ryan
7 years ago

  • Milestone changed from 3.4 to Future Release

#6 @ericlewis
5 years ago

  • Keywords close added

Keyboard shortcuts don't work at all in Chrome, and push your crop selection to the edge immediately in Firefox.

I suggest we maybelater here, and revisit this when we redo the entire image editor experience someday.

#7 follow-up: @SergeyBiryukov
5 years ago

  • Keywords close removed

Hmm, arrow keys used to work in earlier Firefox versions. I wonder if this could be a regression.

Now moving the selection with Shift + arrow keys consistently causes Firefox to crash after a few attempts. We should either fix that or disable the keys.

#8 in reply to: ↑ 7 @SergeyBiryukov
5 years ago

Replying to SergeyBiryukov:

Now moving the selection with Shift + arrow keys consistently causes Firefox to crash after a few attempts.

Also noted in https://make.wordpress.org/docs/2014/04/16/wordpress-3-9-codex-updates/#comment-29068.

#9 @chriscct7
4 years ago

  • Focuses administration added
  • Keywords needs-patch added; has-patch removed
Note: See TracTickets for help on using tickets.