Default registration assumptions in WP Multisite

[terryjsmith]

By default, when you create a new site, it does not set the "registration" site meta key. However, in wp-signup.php by default it assumes it to "all" and allows users and sites to be created (line 381):

// Main
$active_signup = get_site_option( 'registration' );
if ( !$active_signup )
        $active_signup = 'all';

However, in the network settings page, by default it sets it to none (line 75):

if ( !get_site_option( 'registration' ) )
        update_site_option( 'registration', 'none' );

With the new simple flow from a standalone to multi-site installation, new blogs should likely have it set to none by default or it should be an option during set up.

Props to leenewton for discovery.

[nacin]

populate_network () does indeed set registration => none. I seem to recall that registration was on by default in MU — perhaps this is some code dating back to then?

[wpmuguru]

Replying to nacin:

populate_network () does indeed set registration => none. I seem to recall that registration was on by default in MU — perhaps this is some code dating back to then?

I believe that the default in wp-signup.php was to address the potential where the row had been deleted from the sitemeta table. Changing the default to 'none' in wp-signup.php would be fine.

[wpmuguru]

Moving to 3.6 for review.

[jeremyfelt]

18186.2.diff​ is refreshed against trunk.

[nacin]

In 25112:

Have wp-signup.php match the proper default for the 'registration' network option.

props wpmuguru.
fixes #18186.