WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#18235 closed task (blessed) (fixed)

Clean up remnants from having negative Post_IDs

Reported by: azaozz Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch needs-testing
Focuses: Cc:

Description

We switched to creating new post and having "real" post ID as soon as the user loads the Add New Post screen quite long time ago.

However there is still some code expecting negative post IDs and dealing with attachments added before a draft was saved. Seems it's time to remove it.

Attachments (3)

18235.patch (2.9 KB) - added by azaozz 3 years ago.
Marked the places with old and redundant code
18235.2.patch (4.0 KB) - added by ethitter 3 years ago.
Removed old code as indicated by azaozz, tested editor and QuickPress (JS and non-JS), fixed internal references to wp_write_post.
18235.diff (4.4 KB) - added by markjaquith 3 years ago.
Refreshed patch

Download all attachments as: .zip

Change History (11)

azaozz3 years ago

Marked the places with old and redundant code

comment:1 scribu3 years ago

If the code is redundant it should be removed, rather than having comments around it.

comment:2 ramoonus3 years ago

  • Keywords has-patch added

comment:3 ocean903 years ago

  • Keywords needs-patch added; has-patch removed

ethitter3 years ago

Removed old code as indicated by azaozz, tested editor and QuickPress (JS and non-JS), fixed internal references to wp_write_post.

comment:4 ethitter3 years ago

  • Keywords has-patch added; needs-patch removed

comment:5 ethitter3 years ago

  • Cc ehitter@… added
  • Keywords needs-testing added

markjaquith3 years ago

Refreshed patch

comment:6 markjaquith3 years ago

  • Owner set to azaozz
  • Status changed from new to reviewing

Refreshed the patch. Basic testing only. azaozz, can you take this one, since you were the one to mark up the areas in the first place?

comment:7 markjaquith3 years ago

  • Type changed from enhancement to task (blessed)

Not an enhancement.

comment:8 azaozz3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In [18823]:

Clean up remnants from having negative Post_IDs, props markjaquith, fixes #18235

Note: See TracTickets for help on using tickets.