Changing domain for a network blog make faulty changes in database

[darkwhispering]

When changing the domain for a network blog, if the network is set up on a subdomain and using sub-folder options for blogs, the save to the database is faulty, saving wrong urls.

The network main site uses eg ​http://my.blog.com and the blogs has ​http://my.blog.com/blog1

When changing the domain for blog1 in "Network admin -> All Sites -> Edit blog1" and choose to also update "home and siteurl" the new url for home and site become ​http://blog.com/blog1/my

Happens in both Firefox 5 and Safari 5.1

[SergeyBiryukov]

Cannot reproduce. Have you tried with all plugins deactivated?

[darkwhispering]

All plugins is deactivated and the installation is fresh, but it is local, forgot to mention that is the above description.

I and a co-worker of mine have this bug/problem with fresh localhost WP install on Mac OS X Snow Leopard and Lion using the built-in apache and mysql.

[SergeyBiryukov]

I've created the exact same structure on a local installation of 3.3-trunk, but whatever I enter into Domain and Path fields for blog1 and whether I check “Update siteurl and home as well” or not, it just saves what I entered.

I may be missing some step. What are the domain and path you set there?

[darkwhispering]

1. Installing WP in a subdomain like ​http://my.blog.com
2. Turn it into a Network with the subfolder option so the future blogs will have ​http://my.blog.com/blog1
3. For the "blog1" in network admin I change domain to ​http://my.blog.org and leave the path as it is (blog1)
4. Check the "update siteurl and home as well" checkbox
5. Update
6. Taking a look in the database, and the siteurl and home url now looks "​http://blog.org/blog1/my

I have not yet done a new install myself, will do that soon, and then try this again to see what happens.

[SergeyBiryukov]

Ah, I didn't look in the database, because Edit Site screen still displayed valid data. Now I see it.

[darkwhispering]

Ah, yes. The site displays right, but the data in the database get saved wrong.

[SergeyBiryukov]

Introduced in [12978] as a fix #12119:

$blog_address = get_blogaddress_by_domain($_POST['blog']['domain'], $_POST['blog']['path']); 

This is the only place in core where get_blogaddress_by_domain() is used.

Related WPMU changeset:
​r266. If I had to guess, it has something to do with WPMU working in a subfolder.

Not sure if it's a good idea to change get_blogaddress_by_domain() due to backward compatibility reasons, so I've attached patches with two different attempts to fix the issue.

[markoheijnen]

In my opinion opinion this should be fix soon. This will break WordPress functionality since the url can't be access.

[SergeyBiryukov]

Version number indicates when the bug was initially introduced.

[SergeyBiryukov]

Related: #20544

[jeremyfelt]

Moving to 3.7 for discussion, this seems a little ugly to be hanging out there.

[nacin]

I've run into this as well. get_blogaddress_by_domain() seems pretty lame and should probably just get axed once it is no longer used here.

Not sure why one patch checks HTTP_HOST. The other patch seems sufficient — but I'll note that should be esc_url_raw().

It seems like the changes in [12978] shouldn't have happened. Maybe ryan has some ideas. A straight update_option() makes the most sense — the original check occurring before [12978] was unnecessary anyway as update_option() would have handled the equals comparison.

[ryan]

I recall nothing. The direction of 18242.patch seems fine.

[SergeyBiryukov]

Related: #25057

[jeremyfelt]

18242.3.diff​ is @SergeyBiryukov's first patch with esc_url_raw()

[nacin]

In 25261:

Stop using get_blogaddress_by_domain() when updating the siteurl/homeurl from the network admin.

props jeremyfelt, SergeyBiryukov.
fixes #18242. see #25235.

[nacin]

Maybe this should handle things like trimming/adding forward slashes to ensure that the domain and path come together well? Also, these values could probably benefit from stripping backslashes, as they come directly from $_POST.

[jeremyfelt]

See #18117 for related ugliness on slashes for that screen. There could be several areas where that should be tightened up.

[jeremyfelt]

18117.diff on #18117 should address remaining concerns here as well.

[nacin]

Closing this as fixed then.